From 44c2a7bfc5f073004abb0644a1796cf391b8fb4c Mon Sep 17 00:00:00 2001 From: Decoder Date: Wed, 13 May 2026 02:41:22 -0700 Subject: [PATCH] =?UTF-8?q?release:=20cut=20v1.0.1=20=E2=80=94=20fix=20jav?= =?UTF-8?q?adoc=20refs=20broken=20during=20v1.0=20rename?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The v1.0.0 Maven Central publish failed because two javadoc {@link Result#tables()} references survived the @table → @dataset rename (BindRow.java line 16 and ResultAccessorsTest.java line 15). The strict javadoc check inside the publish workflow fails the build; nothing reaches Maven Central. Fix updates both references to {@link Result#datasets()}, bumps the Gradle version from 1.0.0 to 1.0.1, and adds a [1.0.1] section to the CHANGELOG. No code or wire-format change versus v1.0.0; the v1.0.0 tag remains in git for archaeology, but its Maven Central artifact was never published. After merge, tag v1.0.1 on main; publish workflow re-runs against the clean javadoc. --- CHANGELOG.md | 10 ++++++++++ build.gradle.kts | 2 +- pxf/src/main/java/org/protowire/pxf/BindRow.java | 2 +- .../java/org/protowire/pxf/ResultAccessorsTest.java | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1a27b62..8d75ad3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,16 @@ format changes. ## [Unreleased] +## [1.0.1] — 2026-05-13 + +Patch release fixing the Maven Central publish for v1.0.0. Two +javadoc `{@link Result#tables()}` references — in +`BindRow` and `ResultAccessorsTest` — survived the v1.0 rename +and broke the strict javadoc check inside the publish workflow. +Updated to `{@link Result#datasets()}`. No code or wire-format +change versus v1.0.0; the v1.0.0 tag exists in git but its +Maven Central artifact was never published. + ## [1.0.0] — 2026-05-13 First major-version cut. Implements the three one-time spec changes diff --git a/build.gradle.kts b/build.gradle.kts index 4ccc01a..44fa79c 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -12,7 +12,7 @@ plugins { allprojects { group = "org.protowire" - version = "1.0.0" + version = "1.0.1" repositories { mavenCentral() diff --git a/pxf/src/main/java/org/protowire/pxf/BindRow.java b/pxf/src/main/java/org/protowire/pxf/BindRow.java index 6c96092..3d5c6f0 100644 --- a/pxf/src/main/java/org/protowire/pxf/BindRow.java +++ b/pxf/src/main/java/org/protowire/pxf/BindRow.java @@ -13,7 +13,7 @@ * Per-row proto-binding helper for {@code @dataset} rows. Sits atop the * streaming {@link DatasetReader} (via {@link DatasetReader#scan}) and is also * exported as a standalone helper for callers that iterate the - * materializing path's {@link Result#tables()} rows. + * materializing path's {@link Result#datasets()} rows. * *

Implementation strategy: convert each non-{@code null} cell back to * its PXF text representation, concatenate as a {@code = \n} diff --git a/pxf/src/test/java/org/protowire/pxf/ResultAccessorsTest.java b/pxf/src/test/java/org/protowire/pxf/ResultAccessorsTest.java index 132873a..a8ef340 100644 --- a/pxf/src/test/java/org/protowire/pxf/ResultAccessorsTest.java +++ b/pxf/src/test/java/org/protowire/pxf/ResultAccessorsTest.java @@ -12,7 +12,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue; /** - * Verifies that {@link Result#directives()} and {@link Result#tables()} + * Verifies that {@link Result#directives()} and {@link Result#datasets()} * are populated by {@link UnmarshalOptions#unmarshalFull} (the decode * path now records the side-channel directives the prior PRs only * skipped). Mirrors the Go-port test