fix: gen_sdk_package.sh#402
Open
teocns wants to merge 1 commit into
Open
Conversation
Filter out SDK symlink entries that reference the same SDK, retaining the most verbose version name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/gen_sdk_package.sh redundantly packages symlinks pointing to the same SDK, resulting in duplicates
In this case
MacOS13andMacOS13.3are symlinks that point to the same SDK. The script should be able to detect this and not package the same SDK twice.The implemented change filters out SDK symlink entries that reference the same SDK, retaining the one with the verbose-most version (minor)