Support Traversable for file= in config.get#50
Merged
Conversation
Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for Traversable in config.get file parameter
Support Mar 19, 2026
Traversable for file= in config.get
nathanjmcdougall
requested changes
Mar 19, 2026
| file: Configuration file to read from (defaults to "config.yml"). If the file | ||
| isn't found at the location specified, then parent directories are | ||
| searched for a file of the same name. | ||
| file: Configuration file to read from (defaults to "config.yml"). Accepts |
…r, fix Python 3.10 import Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
|
nathanjmcdougall
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0 New Issues
0 Fixed Issues
0 Accepted Issues
config.get(file=files("pkg.config").joinpath("sites.yaml"))raises a pyrightreportArgumentTypeerror becausefileonly acceptsstr | Path, notTraversable.Changes
src/ruru/config.py: Widenfileparameter type tostr | Path | Traversable. When aTraversableis passed, it's used directly —find_config_file(parent directory search) is bypassed since it doesn't apply to package resources.tests/ruru/config/test_config.py: Add test exercising theTraversablecode path via a concreteTraversablewrapper.Original prompt
config.getshould supportTraversableforfile=#49✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.