update scap.go and parse_arf_result.go to simplify modification on ComplianceAsCode rules

[tmishina]

Purpose: to simplify ComplianceAsCode rules (avoid introducing new value for yamlfile_value template)

Idea: updating scap.go and parse_arf_result.go again to leverage following features.

1. API resource collector distinguishes ResourcePath and DumpPath
2. scap.go knows both default value and custom value of variable

Let’s talk with an example case:

• default: /api/v1/namespaces/openshift-apiserver/configmaps/config
• templating: /api/v1/namespaces/{{.openshift_apiserver_ns}}/configmaps/{{.openshift_apiserver_config}}

In this case, values should be as follows.

name	default	custom
openshift_apiserver_ns	openshift-apiserver	my-ns
openshift_apiserver_config	config	my-config

When parse_arf_result.go process warnings element, it should be invoked from scap.go with both default and custom value list, and it should do:

1. render template for DumpPath with default values: /api/v1/namespaces/openshift-apiserver/configmaps/config
2. render template for ResourcePath with custom values: /api/v1/namespaces/my-ns/configmaps/my-config
3. get resource from ResourcePath and save it as DumpPath
4. oscap can perform scan for DumpPath as if it comes from default path
5. The scan output (ARF report) contains the warnings element, and therefore user can understand that the check target resource path was /api/v1/namespaces/my-ns/configmaps/my-config.

[Vincent056]

I think it looks good overall! for the first point, we will probably have a placeholder for namespaces.

default: /api/v1/namespaces//openshift-apiserver/configmaps/config

[tmishina]

@Vincent056 thank you for your review!

for the first point, we will probably have a placeholder for namespaces.

Sorry but I'm not clear about this, could you explain about placeholder here?

[Vincent056]

Sorry about the noise, I think this looks good!

[tmishina]

@Vincent056 Thank you, I created a PR. Let's continue discussion on the PR.