Dear maintainers of {sl3},
I wanted to suggest that I may have found a bug in the cv_sl function.
On line 85 there appears to be a hardcoded [[1]] where I would expect that it should be [[i]].
The code references cv_sl_fit$fit_object$fold_fits[[i]] throughout in several places above, but on line 85 uses cv_sl_fit$fit_object$fold_fits[[1]].
|
sl_pred_i <- cv_sl_fit$fit_object$fold_fits[[1]]$predict(valid_task_i) |
I spoke about this with @nhejazi earlier today and he encouraged me to file an issue to document this.
Best,
Christian
Dear maintainers of
{sl3},I wanted to suggest that I may have found a bug in the
cv_slfunction.On line 85 there appears to be a hardcoded
[[1]]where I would expect that it should be[[i]].The code references
cv_sl_fit$fit_object$fold_fits[[i]]throughout in several places above, but on line 85 usescv_sl_fit$fit_object$fold_fits[[1]].sl3/R/cv_sl.R
Line 85 in 0e8f236
I spoke about this with @nhejazi earlier today and he encouraged me to file an issue to document this.
Best,
Christian