From 38e5a25a91846ddfe3eadd9983671c8719705b97 Mon Sep 17 00:00:00 2001
From: TJ Kolleh <tinatuh@gmail.com>
Date: Wed, 8 Apr 2026 21:44:59 -0400
Subject: [PATCH] fix(ci): consolidate LuaRocks publication to tag-triggered
 workflow

- Remove LuaRocks publication from release-please.yml (commented out)
- Update publish.yml with verbose lx upload for better debugging
- Standardize on ubuntu-24.04 across all workflows
- Add explanatory comments about consolidation
---
 .github/workflows/publish.yml        |  6 ++++--
 .github/workflows/release-please.yml | 18 +++++++++++-------
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 98e87d3..f444079 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -55,9 +55,11 @@ jobs:
           fi
           
           echo "✓ Rockspec valid: $ROCKSPEC"
-          rm -f "$ROCKSPEC"  # Clean up, lx upload will regenerate
+           rm -f "$ROCKSPEC"  # Clean up, lx upload will regenerate
 
+      # Sole LuaRocks publication point - uses lx upload which has built-in JSON
+      # handling and doesn't require system Lua JSON libraries
       - name: Upload to LuaRocks
-        run: lx --lua-version 5.1 upload
+        run: lx --lua-version 5.1 upload --verbose
         env:
           LUX_API_KEY: ${{ secrets.LUX_API_KEY }}
diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml
index 8d3e0cd..5d0fa1a 100644
--- a/.github/workflows/release-please.yml
+++ b/.github/workflows/release-please.yml
@@ -13,7 +13,7 @@ permissions:
 jobs:
   release:
     name: Release
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04
     steps:
       - uses: googleapis/release-please-action@v4
         id: release
@@ -74,9 +74,13 @@ jobs:
         run: |
           gh release upload ${{ steps.release.outputs.tag_name }} roda roda.sha256 *.rockspec
 
-      - name: Publish to LuaRocks
-        if: ${{ steps.release.outputs.release_created }}
-        env:
-          LUAROCKS_API_KEY: ${{ secrets.LUAROCKS_API_KEY }}
-        run: |
-          luarocks upload *.rockspec --api-key=${LUAROCKS_API_KEY}
+      # LuaRocks publication moved to publish.yml workflow (tag-triggered)
+      # to avoid dependency issues and simplify debugging. The publish.yml
+      # workflow uses lx upload which has built-in JSON handling and doesn't
+      # require system Lua JSON libraries like luarocks upload does.
+      # - name: Publish to LuaRocks
+      #   if: ${{ steps.release.outputs.release_created }}
+      #   env:
+      #     LUAROCKS_API_KEY: ${{ secrets.LUAROCKS_API_KEY }}
+      #   run: |
+      #     luarocks upload *.rockspec --api-key=${LUAROCKS_API_KEY}