-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathTODO
More file actions
6 lines (6 loc) · 709 Bytes
/
Copy pathTODO
File metadata and controls
6 lines (6 loc) · 709 Bytes
1
2
3
4
5
6
+ Pagination of the index page
+ Status alerts on both the index page and the editor page are broken
+ The mappings duplicator requires styling on the new and edit pages (spacing)
+ Rather than use an array of known structure to pass an importer around, an object would be better. When saving an importer it would create a subclass of the importer class that simply calls the constructor with the saved values. Creating an importer from the form data would simply involve calling the importer class constructor with the correct parameters.
+ Add type hints for each object and array passed to a function
+ Add type checks at the top of each function that accepts a primitive type (is_bool(), is_string() etc)