From 932db9a785f04143f0594921a572a67f2b922da9 Mon Sep 17 00:00:00 2001 From: nofaralfasi Date: Wed, 24 Jun 2026 17:00:28 +0300 Subject: [PATCH 1/2] Update Inventory Upload docs link for new Insights chapter Switch `getInventoryDocsUrl` to the new documentation location in `Administering_Project` (`configuring-project-server-for-cloud-connection`) and update the helper unit test to assert the new guide/chapter mapping. --- webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js | 4 ++-- .../__tests__/ForemanInventoryHelpers.test.js | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js b/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js index 03a338002..43a81e1e3 100644 --- a/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js +++ b/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js @@ -7,8 +7,8 @@ export const inventoryUrl = path => export const getInventoryDocsUrl = () => getDocsURL( - 'Managing_Hosts', - 'configuring-foreman-server-for-cloud-connection' + 'Administering_Project', + 'configuring-project-server-for-cloud-connection' ); export const getSubscriptionServiceDocsUrl = () => diff --git a/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js b/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js index 6ab91167b..a5af22fc8 100644 --- a/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js +++ b/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js @@ -7,11 +7,11 @@ import { getInventoryDocsUrl, isExitCodeLoading } from '../ForemanInventoryHelpe describe('ForemanInventoryUpload helpers', () => { describe('getInventoryDocsUrl', () => { - it('requests the Managing Hosts guide at the cloud connection chapter', () => { + it('requests the admin guide cloud connection chapter', () => { getInventoryDocsUrl(); expect(getDocsURL).toHaveBeenCalledWith( - 'Managing_Hosts', - 'configuring-foreman-server-for-cloud-connection' + 'Administering_Project', + 'configuring-project-server-for-cloud-connection' ); }); }); From d5780d123b4debe513ef26da5d1ceb3f98a5c4b9 Mon Sep 17 00:00:00 2001 From: Nofar Date: Tue, 30 Jun 2026 17:40:54 +0300 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Lena Ansorge --- webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js | 2 +- .../__tests__/ForemanInventoryHelpers.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js b/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js index 43a81e1e3..1f54aa34c 100644 --- a/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js +++ b/webpack/ForemanInventoryUpload/ForemanInventoryHelpers.js @@ -8,7 +8,7 @@ export const inventoryUrl = path => export const getInventoryDocsUrl = () => getDocsURL( 'Administering_Project', - 'configuring-project-server-for-cloud-connection' + 'configuring-foreman-server-for-cloud-connection' ); export const getSubscriptionServiceDocsUrl = () => diff --git a/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js b/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js index 95c7ee4cb..6f3e5461f 100644 --- a/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js +++ b/webpack/ForemanInventoryUpload/__tests__/ForemanInventoryHelpers.test.js @@ -14,7 +14,7 @@ describe('ForemanInventoryUpload helpers', () => { getInventoryDocsUrl(); expect(getDocsURL).toHaveBeenCalledWith( 'Administering_Project', - 'configuring-project-server-for-cloud-connection' + 'configuring-foreman-server-for-cloud-connection' ); }); });