Remove unused advisor_engine_config API endpoint#1226
Open
jeremylenz wants to merge 1 commit into
Open
Conversation
IoP detection was refactored in b53390f to use server-side page metadata instead of this endpoint. The frontend now reads useForemanContext().metadata.foreman_rh_cloud.iop, making the GET /api/v2/rh_cloud/advisor_engine_config endpoint dead code. Removes the controller, route, permission entry, and two unused JS constants (ADVISOR_ENGINE_CONFIG_KEY, ADVISOR_ENGINE_CONFIG_PATH). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
nofaralfasi
approved these changes
Jun 30, 2026
nofaralfasi
left a comment
nofaralfasi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks @jeremylenz!
Collaborator
Author
|
waiting to merge until Robottelo automation is passing with PRT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v2/rh_cloud/advisor_engine_configendpoint (controller, route, permission entry)ADVISOR_ENGINE_CONFIG_KEYandADVISOR_ENGINE_CONFIG_PATHuseForemanContext().metadata.foreman_rh_cloud.iop) instead of this API call, making the endpoint dead codeTest plan
bundle exec rake test:foreman_rh_cloud— 537 tests, 0 failuresnpm test— 191 tests pass (3 pre-existing failures from missing Foreman mock modules)grep -r "advisor_engine_config"confirms no remaining references🤖 Generated with Claude Code