From 9d44d1826d78dfef9c91b4d3bcd76f035fdacc23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Gajdu=C5=A1ek?= Date: Tue, 16 Jun 2026 10:51:19 +0200 Subject: [PATCH] Remove foreman::cli::virt_who_configure The puppet-foreman module dropped the foreman::cli::virt_who_configure class (theforeman/puppet-foreman@f345cfa), causing foreman-installer nightly builds to fail with: File not found .../foreman/manifests/cli/virt_who_configure.pp Remove the class from the katello scenario answers, add a migration to clean up existing answer files, and update spec fixtures. Co-Authored-By: Claude Opus 4.6 --- config/katello-answers.yaml | 1 - .../260616084754-remove-virt-who-configure-cli.rb | 1 + .../katello-answers-after.yaml | 1 - .../katello-answers-before.yaml | 1 - .../pulpcore-migration-rpm-only/katello-answers-after.yaml | 1 - .../pulpcore-migration-rpm-only/katello-answers-before.yaml | 1 - spec/fixtures/pulpcore-migration/katello-answers-after.yaml | 1 - 7 files changed, 1 insertion(+), 6 deletions(-) create mode 100644 config/katello.migrations/260616084754-remove-virt-who-configure-cli.rb diff --git a/config/katello-answers.yaml b/config/katello-answers.yaml index 8c63c373..9b60f8f0 100644 --- a/config/katello-answers.yaml +++ b/config/katello-answers.yaml @@ -40,7 +40,6 @@ foreman::cli::scc_manager: false foreman::cli::ssh: false foreman::cli::tasks: false foreman::cli::templates: false -foreman::cli::virt_who_configure: false foreman::cli::webhooks: false foreman::compute::ec2: false foreman::compute::libvirt: false diff --git a/config/katello.migrations/260616084754-remove-virt-who-configure-cli.rb b/config/katello.migrations/260616084754-remove-virt-who-configure-cli.rb new file mode 100644 index 00000000..139d116d --- /dev/null +++ b/config/katello.migrations/260616084754-remove-virt-who-configure-cli.rb @@ -0,0 +1 @@ +answers.delete('foreman::cli::virt_who_configure') diff --git a/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-after.yaml b/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-after.yaml index ae679639..a0ac6fa1 100644 --- a/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-after.yaml +++ b/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-after.yaml @@ -12,7 +12,6 @@ foreman::cli::rh_cloud: false foreman::cli::salt: false foreman::cli::scc_manager: false foreman::cli::ssh: false -foreman::cli::virt_who_configure: false foreman::cli::webhooks: false foreman::compute::ec2: false foreman::compute::libvirt: false diff --git a/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-before.yaml b/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-before.yaml index e33de14c..bf4a183a 100644 --- a/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-before.yaml +++ b/spec/fixtures/pulpcore-migration-dont-use-content-plugins-on-upgrades/katello-answers-before.yaml @@ -2,7 +2,6 @@ foreman::cli: true foreman::cli::ansible: false foreman::cli::azure: false foreman::cli::kubevirt: false -foreman::cli::virt_who_configure: false foreman::compute::ec2: false foreman::compute::gce: false foreman::compute::libvirt: false diff --git a/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-after.yaml b/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-after.yaml index ad376daf..c07c824c 100644 --- a/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-after.yaml +++ b/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-after.yaml @@ -12,7 +12,6 @@ foreman::cli::rh_cloud: false foreman::cli::salt: false foreman::cli::scc_manager: false foreman::cli::ssh: false -foreman::cli::virt_who_configure: false foreman::cli::webhooks: false foreman::compute::ec2: false foreman::compute::libvirt: false diff --git a/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-before.yaml b/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-before.yaml index c4fc5dcf..967426ee 100644 --- a/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-before.yaml +++ b/spec/fixtures/pulpcore-migration-rpm-only/katello-answers-before.yaml @@ -2,7 +2,6 @@ foreman::cli: true foreman::cli::ansible: false foreman::cli::azure: false foreman::cli::kubevirt: false -foreman::cli::virt_who_configure: false foreman::compute::ec2: false foreman::compute::gce: false foreman::compute::libvirt: false diff --git a/spec/fixtures/pulpcore-migration/katello-answers-after.yaml b/spec/fixtures/pulpcore-migration/katello-answers-after.yaml index c4c1bfed..6e586e6c 100644 --- a/spec/fixtures/pulpcore-migration/katello-answers-after.yaml +++ b/spec/fixtures/pulpcore-migration/katello-answers-after.yaml @@ -12,7 +12,6 @@ foreman::cli::rh_cloud: false foreman::cli::salt: false foreman::cli::scc_manager: false foreman::cli::ssh: false -foreman::cli::virt_who_configure: false foreman::cli::webhooks: false foreman::compute::ec2: false foreman::compute::libvirt: false