From 66c113f1ab621fa3ced7a55be78e54ea31cff937 Mon Sep 17 00:00:00 2001 From: Himess <95512809+Himess@users.noreply.github.com> Date: Thu, 23 Jan 2025 02:57:48 +0300 Subject: [PATCH 1/3] Update GroupNFT.sol --- contracts/GroupNFT.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/GroupNFT.sol b/contracts/GroupNFT.sol index a023ef425..a731bc56e 100644 --- a/contracts/GroupNFT.sol +++ b/contracts/GroupNFT.sol @@ -100,7 +100,7 @@ contract GroupNFT is IGroupNFT, ERC721Upgradeable, AccessManagedUpgradeable, UUP '"name": "Story Protocol IP Assets Group #', id.toString(), '",', - '"description": IPAsset Group",', + '"description": "IPAsset Group",', '"external_url": "https://protocol.storyprotocol.xyz/ipa/', id.toString(), '",', From a42f09720d7eca10437c007f6d7ebfa9d29d182e Mon Sep 17 00:00:00 2001 From: Himess <95512809+Himess@users.noreply.github.com> Date: Thu, 23 Jan 2025 03:04:46 +0300 Subject: [PATCH 2/3] Update IPAccountImpl.sol --- contracts/IPAccountImpl.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contracts/IPAccountImpl.sol b/contracts/IPAccountImpl.sol index c49b2a984..5571e18ec 100644 --- a/contracts/IPAccountImpl.sol +++ b/contracts/IPAccountImpl.sol @@ -223,7 +223,7 @@ contract IPAccountImpl is ERC6551, IPAccountStorage, IIPAccount { } } - /// @dev Updates the IP Account's state all execute transactions. + /// @dev Updates the IP Account's state for all executed transactions. /// @param to The "target" of the execute transactions. /// @param value The amount of Ether to send. /// @param data The data to send along with the transaction. @@ -238,7 +238,7 @@ contract IPAccountImpl is ERC6551, IPAccountStorage, IIPAccount { /// @dev Override Solady 6551 _isValidSigner function. /// @param signer The signer to check - /// @param extraData The extra data to check against, it should bethe address of the recipient for IPAccount + /// @param extraData The extra data to check against, it should be the address of the recipient for IPAccount /// @param context The context for validating the signer /// @return bool is true if the signer is valid, false otherwise function _isValidSigner( From 763d1532c673bba78a6ee2c3870bcded70ef3edd Mon Sep 17 00:00:00 2001 From: Himess <95512809+Himess@users.noreply.github.com> Date: Thu, 23 Jan 2025 03:11:35 +0300 Subject: [PATCH 3/3] Update StorageLayoutCheck.s.sol --- script/foundry/utils/upgrades/StorageLayoutCheck.s.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/script/foundry/utils/upgrades/StorageLayoutCheck.s.sol b/script/foundry/utils/upgrades/StorageLayoutCheck.s.sol index 271424fa3..dc7f5067c 100644 --- a/script/foundry/utils/upgrades/StorageLayoutCheck.s.sol +++ b/script/foundry/utils/upgrades/StorageLayoutCheck.s.sol @@ -50,7 +50,7 @@ contract StorageLayoutChecker is Script { uint8 i = 0; // npx @openzeppelin/upgrades-core validate --requireReference inputBuilder[i++] = "npx"; - inputBuilder[i++] = string.concat("@openzeppelin/upgrades-core"); + inputBuilder[i++] = "@openzeppelin/upgrades-core"; inputBuilder[i++] = "validate"; inputBuilder[i++] = string.concat(outDir, "/build-info"); @@ -62,4 +62,4 @@ contract StorageLayoutChecker is Script { return inputs; } -} \ No newline at end of file +}