Skip to content

redirect is not a early terminating method, but httpError is #28

Description

@beerbohmdo

In the phpstan.neon the redirect method is defined as a earlyTerminatingMethodCalls, but this method does not exit it returns a HTTPResponse.

(Yes the method has the side-effect, that is set the response object of the controller - but it does not early exits ...)

httpError which throws a HTTPResponse_Exception should be marked as earlyTerminating instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions