EntityExtensions.ShouldInvert hook impacts performance

[karl2883]

Hi! I have been profiling modded maps recently. I noticed that the EntityExtensions.ShouldInvert() hook has bad performance because of its DynamicData usage (see image from profiler), which affects SetLiftSpeed() for every actor and with that Update() for every actor.

(I have also contacted ChroniaHelper about the Tera Block hook which has a similar issue).
This isn't an extremely big deal since the hooks are only active for GravityHelper maps as far as I'm aware, but this still affects the performance of a fair number of maps (to some extent) I think :p
It seems like it would probably (?) make sense to use a GravityComponent field instead of DynamicData.
Lmk if you have any questions :)

[swoolcock]

Gravity type is already stored in GravityComponent. The DynamicData usage here is a legacy thing I never got around to removing. I doubt the performance hit is really that much, but I'll consider removing it in future.

Edit:
How are you profiling that? If it's based on average time taken then it should be low, but if it's based on the total time per frame then I can understand it being high as it's likely being called hundreds of times per frame just based on the number of places in the game it needs to be checked.

[karl2883]

I'm profiling it with Jetbrains DotTrace, which is based on sampling, so it approximates the total time per frame. The DynamicData usage in that hook takse up about 0.9% of Update stage time in the collab map I'm profiling (which uses entity gravity containers from Chrono Helper) - which is not extremely high but probably worth fixing (I'm basically just going through all the hooks that take up unnecessary amounts of time in the maps).

[swoolcock]

What is an entity gravity container... that's nothing to do with Gravity Helper.

[karl2883]

yeah, they are from Chrono Helper, they are not the main subject here, they just cause affected entities to use Actor functions which means the hook runs relatively often, so I mentioned it as context