Skip to content

Commit e166a58

Browse files
committed
chore(ci): moves workflow permissions to individual jobs
makes sonar happy, although, in our specific case there's _no_ additional security benefit
1 parent c6e7a85 commit e166a58

1 file changed

Lines changed: 8 additions & 40 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
11
name: ci
2-
permissions:
3-
contents: read
4-
pull-requests: read
5-
actions: read
62

73
on:
84
push:
@@ -28,6 +24,10 @@ defaults:
2824

2925
jobs:
3026
check-linux:
27+
permissions:
28+
contents: read
29+
pull-requests: read
30+
actions: read
3131
strategy:
3232
fail-fast: false
3333
matrix:
@@ -97,6 +97,10 @@ jobs:
9797
env:
9898
PLATFORM: windows-latest
9999
NO_COLOR: 1
100+
permissions:
101+
contents: read
102+
pull-requests: read
103+
actions: read
100104
runs-on: windows-latest
101105
steps:
102106
- uses: actions/checkout@v6
@@ -116,39 +120,3 @@ jobs:
116120
npm run build
117121
- run: npm run depcruise
118122
- run: npx mocha --invert --fgrep "#do-not-run-on-windows"
119-
120-
# for #reasons the run step takes forever to complete on the ci - while
121-
# running fine locally. Something to figure out another time.
122-
# check-berry-integration:
123-
# runs-on: ubuntu-latest
124-
# steps:
125-
# - uses: actions/checkout@v6
126-
# - uses: actions/cache@v5
127-
# with:
128-
# path: |
129-
# .yarn
130-
# .yarnrc.yml
131-
# .pnp.js
132-
# yarn.lock
133-
# key: ${{env.NODE_LATEST}}@${{env.PLATFORM}}-build-${{hashFiles('package.json')}}
134-
# restore-keys: |
135-
# ${{env.NODE_LATEST}}@${{env.PLATFORM}}-build-
136-
# - uses: actions/setup-node@v6
137-
# with:
138-
# node-version: ${{env.NODE_LATEST}}
139-
# - name: install & build
140-
# run: |
141-
# rm -f .npmrc
142-
# yarn set version berry
143-
# YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn
144-
# - name: forbidden dependency check
145-
# run: |
146-
# yarn --version
147-
# yarn depcruise
148-
# # testing doesn't work as the tests are esm and berry, with pnp enabled,
149-
# # doesn't support esm yet.
150-
# # - name: test coverage
151-
# # run: |
152-
# # node --version
153-
# # yarn --version
154-
# # yarn test:cover

0 commit comments

Comments
 (0)