fix: align form number handling with HTML spec#16320
Draft
elliott-with-the-longest-name-on-github wants to merge 1 commit into
Draft
fix: align form number handling with HTML spec#16320elliott-with-the-longest-name-on-github wants to merge 1 commit into
form number handling with HTML spec#16320elliott-with-the-longest-name-on-github wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/a23295b9becb0cbf0ec7668cb93880d7382e5042Open in |
🦋 Changeset detectedLatest commit: a23295b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Cursor is still jumping: Screen.Recording.2026-07-10.at.3.47.24.PM.mov |
Rich-Harris
reviewed
Jul 10, 2026
| * @returns {number | undefined} | ||
| */ | ||
| function parse_number_value(value) { | ||
| if (value === '' || !valid_floating_point_number_regex.test(value)) return undefined; |
Member
There was a problem hiding this comment.
can an invalid value other than '' even happen? I can't find a way to enter one
Member
|
marking this as draft |
Rich-Harris
marked this pull request as draft
July 14, 2026 00:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16270
Basically, the problem is that we were handling numbers in a HTML-spec-incompliant way. I've adjusted the handling so that we:
undefinedOne alternative approach to this would be to save the last valid number we got and use that, but that seems... wrong.