Enforce extra new line at end of file

[sunkan]

@bix0r

Enforce extra new line at end of file

At the moment the files you create are missing newline at end file

https://github.com/stefna/codestyle/blob/try-catch/tests/Sniffs/ControlStructures/TryCatchDeclarationSniffTest.php#L17

There should always be an empty newline at end of file

[dcolt]

@sunkan
Just so I'm sure I understand you.

You want us to break PSR-12, All PHP files MUST end with a single blank line. and PSR-2 All PHP files MUST end with a non-blank line, terminated with a single LF.

Every tool at my disposal shows I'm having a empty blank line.

As far as I can tell, github file view behaves in a similar way my editor does. If the last line is an empty blank line, it doesn't show it, as it has no content.

The file is ending with a newline (0x0a) after the }, but my understanding is you're expecting 0a0a 2x new lines at the end of the file?

$ xxd tests/Sniffs/ControlStructures/TryCatchDeclarationSniffTest.php 
00000000: 3c3f 7068 7020 6465 636c 6172 6528 7374  <?php declare(st
00000010: 7269 6374 5f74 7970 6573 3d31 293b 0a0a  rict_types=1);..
00000020: 6e61 6d65 7370 6163 6520 5374 6566 6e61  namespace Stefna
00000030: 5465 7374 5c53 6e69 6666 735c 436f 6e74  Test\Sniffs\Cont
00000040: 726f 6c53 7472 7563 7475 7265 733b 0a0a  rolStructures;..
00000050: 7573 6520 5374 6566 6e61 5465 7374 5c53  use StefnaTest\S
00000060: 6e69 6666 735c 5465 7374 4361 7365 3b0a  niffs\TestCase;.
00000070: 0a63 6c61 7373 2054 7279 4361 7463 6844  .class TryCatchD
00000080: 6563 6c61 7261 7469 6f6e 536e 6966 6654  eclarationSniffT
00000090: 6573 7420 6578 7465 6e64 7320 5465 7374  est extends Test
000000a0: 4361 7365 0a7b 0a09 7075 626c 6963 2066  Case.{..public f
000000b0: 756e 6374 696f 6e20 7465 7374 5472 7943  unction testTryC
000000c0: 6174 6368 2829 3a20 766f 6964 0a09 7b0a  atch(): void..{.
000000d0: 0909 2474 6869 732d 3e63 6865 636b 4669  ..$this->checkFi
000000e0: 6c65 2827 5472 7943 6174 6368 2729 3b0a  le('TryCatch');.
000000f0: 0a09 0973 656c 663a 3a61 7373 6572 7453  ...self::assertS
00000100: 6e69 6666 4572 726f 7228 2757 6869 7465  niffError('White
00000110: 5370 6163 6542 6574 7765 656e 4272 6163  SpaceBetweenBrac
00000120: 6573 272c 206c 696e 653a 3829 3b0a 0909  es', line:8);...
00000130: 7365 6c66 3a3a 6173 7365 7274 536e 6966  self::assertSnif
00000140: 6645 7272 6f72 2827 456d 7074 7946 696e  fError('EmptyFin
00000150: 616c 6c79 272c 206c 696e 653a 3130 293b  ally', line:10);
00000160: 0a0a 0909 7365 6c66 3a3a 6173 7365 7274  ....self::assert
00000170: 536e 6966 6645 7272 6f72 2827 5768 6974  SniffError('Whit
00000180: 6553 7061 6365 4265 7477 6565 6e42 7261  eSpaceBetweenBra
00000190: 6365 7327 2c20 6c69 6e65 3a31 3629 3b0a  ces', line:16);.
000001a0: 0909 7365 6c66 3a3a 6173 7365 7274 536e  ..self::assertSn
000001b0: 6966 6645 7272 6f72 2827 456d 7074 7946  iffError('EmptyF
000001c0: 696e 616c 6c79 272c 206c 696e 653a 3139  inally', line:19
000001d0: 293b 0a0a 0909 7365 6c66 3a3a 6173 7365  );....self::asse
000001e0: 7274 416c 6c46 6978 6564 496e 4669 6c65  rtAllFixedInFile
000001f0: 2829 3b0a 097d 0a0a 0970 7562 6c69 6320  ();..}...public 
00000200: 6675 6e63 7469 6f6e 2074 6573 7454 7279  function testTry
00000210: 4361 7463 6857 6974 6856 6172 6961 626c  CatchWithVariabl
00000220: 6528 293a 2076 6f69 640a 097b 0a09 0924  e(): void..{...$
00000230: 7468 6973 2d3e 6368 6563 6b46 696c 6528  this->checkFile(
00000240: 2754 7279 4361 7463 6857 6974 6856 6172  'TryCatchWithVar
00000250: 6961 626c 6527 293b 0a0a 0909 7365 6c66  iable');....self
00000260: 3a3a 6173 7365 7274 536e 6966 6645 7272  ::assertSniffErr
00000270: 6f72 2827 456d 7074 7942 6f64 7943 6175  or('EmptyBodyCau
00000280: 6768 7445 7863 6570 7469 6f6e 272c 206c  ghtException', l
00000290: 696e 653a 3829 3b0a 0909 7365 6c66 3a3a  ine:8);...self::
000002a0: 6173 7365 7274 536e 6966 6645 7272 6f72  assertSniffError
000002b0: 2827 456d 7074 7942 6f64 7943 6175 6768  ('EmptyBodyCaugh
000002c0: 7445 7863 6570 7469 6f6e 272c 206c 696e  tException', lin
000002d0: 653a 3133 293b 0a0a 0909 7365 6c66 3a3a  e:13);....self::
000002e0: 6173 7365 7274 416c 6c46 6978 6564 496e  assertAllFixedIn
000002f0: 4669 6c65 2829 3b0a 097d 0a7d 0a         File();..}.}.