Skip to content

apollo_committer: reduce tests boilerplate#14425

Merged
ArielElp merged 1 commit into
mainfrom
ariel/refactor_tests
Jun 9, 2026
Merged

apollo_committer: reduce tests boilerplate#14425
ArielElp merged 1 commit into
mainfrom
ariel/refactor_tests

Conversation

@ArielElp

@ArielElp ArielElp commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

ArielElp commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ArielElp ArielElp force-pushed the ariel/refactor_tests branch from 204f01b to 97d8aec Compare June 9, 2026 15:12
@ArielElp ArielElp force-pushed the ariel/test_edge_case branch from b1f5e2b to 965263d Compare June 9, 2026 15:12
@ArielElp ArielElp force-pushed the ariel/refactor_tests branch from 97d8aec to 1047e7f Compare June 9, 2026 15:21
@ArielElp ArielElp force-pushed the ariel/test_edge_case branch from 965263d to 11ad4ad Compare June 9, 2026 15:21
@ArielElp ArielElp requested a review from yoavGrs June 9, 2026 15:22
@ArielElp ArielElp marked this pull request as ready for review June 9, 2026 15:22
@cursor

cursor Bot commented Jun 9, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only refactor in one file; no production committer logic changes.

Overview
Introduces a shared setup_and_read_paths helper in request_paths_and_commit_block_tests.rs that commits block 0 with a setup state diff (no witnesses), then runs read_paths_and_commit_block at block 1 and returns the response.

revert_removes_witnesses_and_digest and the two Patricia edge proof tests now call this helper instead of duplicating the two-step commit/read setup. Those tests also rename the initial diff variable to setup_state_diff where it is custom. Imports ReadPathsAndCommitBlockResponse for the helper’s return type.

Test behavior is unchanged; this is structural deduplication only.

Reviewed by Cursor Bugbot for commit 46fd17c. Bugbot is set up for automated code reviews on this repo. Configure here.

@ArielElp ArielElp changed the base branch from ariel/test_edge_case to graphite-base/14425 June 9, 2026 15:41
@ArielElp ArielElp force-pushed the ariel/refactor_tests branch from 1047e7f to dd96578 Compare June 9, 2026 15:42
@ArielElp ArielElp force-pushed the graphite-base/14425 branch from 11ad4ad to b5c134f Compare June 9, 2026 15:42

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@ArielElp ArielElp force-pushed the graphite-base/14425 branch from b5c134f to 6559f5c Compare June 9, 2026 17:11
@ArielElp ArielElp force-pushed the ariel/refactor_tests branch from dd96578 to 46fd17c Compare June 9, 2026 17:11
@ArielElp ArielElp changed the base branch from graphite-base/14425 to main June 9, 2026 17:11

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit bc24421 Jun 9, 2026
22 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants