Skip to content

deployment: fix proof manager port of testing node in services#14390

Open
ShahakShama wants to merge 1 commit into
main-v0.14.3from
shahak/fix_missing_port_in_testing_deployment
Open

deployment: fix proof manager port of testing node in services#14390
ShahakShama wants to merge 1 commit into
main-v0.14.3from
shahak/fix_missing_port_in_testing_deployment

Conversation

@ShahakShama

Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented Jun 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single Service port addition for an already-configured component; no application logic changes.

Overview
Exposes proof manager on the hybrid testing node-0 core Kubernetes Service by adding a proof-manager port entry (55012), matching components.proof_manager.port and the shared hybrid core service overlay.

Reviewed by Cursor Bugbot for commit 490adf1. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@matanl-starkware matanl-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).


deployments/sequencer/configs/overlays/hybrid/testing/node-0/services/core.yaml line 94 at r1 (raw file):

    port: 55012
    targetPort: 55012
    protocol: TCP

Move below, keep ports in ascending order

Code quote:

  - name: proof-manager
    port: 55012
    targetPort: 55012
    protocol: TCP

@ShahakShama ShahakShama force-pushed the shahak/fix_missing_port_in_testing_deployment branch from d70f23f to 490adf1 Compare June 4, 2026 14:17

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 1 file.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on ShahakShama).

@ShahakShama ShahakShama left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

@matanl-starkware matanl-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ShahakShama).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants