Skip to content

apollo_batcher: add ReadPathsAndCommitBlock committer task type#14385

Open
yoavGrs wants to merge 1 commit into
apollo_batcher_commit_metrics_refactorfrom
apollo_batcher_read_paths_task_type
Open

apollo_batcher: add ReadPathsAndCommitBlock committer task type#14385
yoavGrs wants to merge 1 commit into
apollo_batcher_commit_metrics_refactorfrom
apollo_batcher_read_paths_task_type

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Adds the task input/output variants and their handling in the state
committer under os_input: the task calls the committer's
read_paths_and_commit_block endpoint and currently discards the returned
Patricia witnesses. Nothing constructs the task yet.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

blockifier: add len and is_empty to AccessedKeys

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Artifacts upload workflows:

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are feature-gated and unused in production paths until something constructs the new task; commitment behavior for existing CommitBlock is unchanged.

Overview
Under the os_input feature, the batcher commitment manager gains a ReadPathsAndCommitBlock committer task alongside existing commit/revert tasks. The state committer invokes the committer’s read_paths_and_commit_block API, keeps only the global root for storage (Patricia witnesses are dropped for now), and routes results through the same commitment finalization path as CommitBlock. Revert-wait and metrics treat this variant like a commit; dedicated metrics are deferred.

In blockifier, AccessedKeys adds len and is_empty over storage keys, contracts, and class hashes—supporting logging/sizing for the new task’s accessed-key count. No caller enqueues ReadPathsAndCommitBlock yet; this is plumbing only.

Reviewed by Cursor Bugbot for commit 3ee7737. Bugbot is set up for automated code reviews on this repo. Configure here.

@yoavGrs yoavGrs requested a review from itamar-starkware June 8, 2026 07:15
@yoavGrs yoavGrs self-assigned this Jun 8, 2026
Adds the task input/output variants and their handling in the state
committer under os_input: the task calls the committer's
read_paths_and_commit_block endpoint and currently discards the returned
Patricia witnesses. Nothing constructs the task yet.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

blockifier: add len and is_empty to AccessedKeys

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yoavGrs yoavGrs force-pushed the apollo_batcher_commit_metrics_refactor branch from daf5ca3 to 6354afd Compare June 9, 2026 10:31
@yoavGrs yoavGrs force-pushed the apollo_batcher_read_paths_task_type branch from 8d6cab6 to 3ee7737 Compare June 9, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants