Skip to content

apollo_batcher: refactor TaskTimer with a timer map per task label#14383

Open
yoavGrs wants to merge 1 commit into
apollo_storage_patricia_proofs_tablefrom
apollo_batcher_task_timer_per_label_map
Open

apollo_batcher: refactor TaskTimer with a timer map per task label#14383
yoavGrs wants to merge 1 commit into
apollo_storage_patricia_proofs_tablefrom
apollo_batcher_task_timer_per_label_map

Conversation

@yoavGrs

@yoavGrs yoavGrs commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Extracts map_for_label and gives ReadPathsAndCommitBlock its own timer map
instead of aliasing the commit map.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented Jun 8, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Observability-only timing refactor in commitment manager; no commit/revert behavior changes beyond correct per-label timer isolation.

Overview
Refactors TaskTimer so each CommitterRequestLabelValue uses its own per-block timer map, with shared lookup via a new map_for_label helper used by start_timer and stop_timer.

Under the os_input feature, ReadPathsAndCommitBlock no longer shares the commit map—it gets a dedicated read_paths_and_commit_block store—so timing for that path is tracked separately from ordinary CommitBlock work at the same height.

Reviewed by Cursor Bugbot for commit 8fb9782. Bugbot is set up for automated code reviews on this repo. Configure here.

@yoavGrs yoavGrs requested a review from itamar-starkware June 8, 2026 07:14
@yoavGrs yoavGrs self-assigned this Jun 8, 2026
Extracts map_for_label and gives ReadPathsAndCommitBlock its own timer map
instead of aliasing the commit map.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yoavGrs yoavGrs force-pushed the apollo_batcher_task_timer_per_label_map branch from fdc71fe to 8fb9782 Compare June 9, 2026 10:31
@yoavGrs yoavGrs force-pushed the apollo_storage_patricia_proofs_table branch from 17bf2cf to 3beeb99 Compare June 9, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants