starknet_committer: fetch patricia paths concurrently

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer: fetch patricia paths concurrently #14283 👈 (View in Graphite)
• starknet_committer: define fetch_contract_storage_paths_concurrently #14282
• starknet_committer: define StoragePathsReadTask #14281
• starknet_patricia_storage: move is_gatherable to ReadOnlyStorage #14280
• apollo_committer,starknet_committer: use blockifier's AccessedKeys #14252
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Changes the block committer’s Patricia proof read path (witness data for commitments); logic is intended to be equivalent between sequential and concurrent modes, but concurrency in storage reads can surface ordering or storage-layer edge cases.

Overview
Patricia witness collection for contract storage tries now goes through fetch_contract_storage_paths, which uses GatherableStorage::gather to fetch per-contract storage proofs in parallel when the DB layer supports it, and falls back to the same sequential loop otherwise.

fetch_all_patricia_paths is refactored: classes/contracts paths are fetched in fetch_classes_and_contracts_patricia_paths, storage proofs are delegated to trie traversal, and the final StarknetForestProofs value is assembled via a new StarknetForestProofs::build helper (moving leaf NodeIndex → ContractAddress conversion out of tree.rs). #[allow(dead_code)] is removed from the storage-path fetch helpers now that they are wired in.

^{Reviewed by Cursor Bugbot for commit da2c6d9. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/starknet_committer/src/patricia_merkle_tree/tree.rs line 255 at r2 (raw file):

        contracts_trie_storage_proofs,
    }
}

non-blocking, but seems like this would look better as StarknetForestProofs::build(..). this is just a data conversion method so not important

Code quote:

fn build_starknet_forest_proofs<Layout>(
    classes_trie_proof: PreimageMap,
    contracts_proof_nodes: PreimageMap,
    contract_leaves: HashMap<NodeIndex, Layout::ContractStateDbLeaf>,
    contracts_trie_storage_proofs: HashMap<ContractAddress, PreimageMap>,
) -> StarknetForestProofs
where
    Layout: DbLayout,
    Layout::ContractStateDbLeaf: Into<ContractState>,
{
    // Convert contract_leaves_data keys from NodeIndex to ContractAddress.
    let contract_leaves_data: HashMap<ContractAddress, ContractState> = contract_leaves
        .into_iter()
        .map(|(idx, contract_state_leaf)| {
            (
        
                try_node_index_into_contract_address(&idx).unwrap_or_else(|_| {
                    panic!(
                        "Converting leaf NodeIndex to ContractAddress should succeed; failed to \
                         convert {idx:?}."
                    )
                }),
                contract_state_leaf.into(),
            )
        })
        .collect();

    StarknetForestProofs {
        classes_trie_proof,
        contracts_trie_proof: ContractsTrieProof {
            nodes: contracts_proof_nodes,
            leaves: contract_leaves_data,
        },
        contracts_trie_storage_proofs,
    }
}

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[ArielElp]

@dorimedini-starkware Good call — moved the conversion logic to StarknetForestProofs::build in types.rs and updated the call site in tree.rs.

[ArielElp]

@ArielElp made 1 comment and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

---

crates/starknet_committer/src/patricia_merkle_tree/tree.rs line 255 at r2 (raw file):

Previously, dorimedini-starkware wrote…

non-blocking, but seems like this would look better as StarknetForestProofs::build(..). this is just a data conversion method so not important

Done

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).