starknet_committer: define fetch_contract_storage_paths_concurrently

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer: fetch patricia paths concurrently #14283
• starknet_committer: define fetch_contract_storage_paths_concurrently #14282 👈 (View in Graphite)
• starknet_committer: define StoragePathsReadTask #14281
• starknet_patricia_storage: move is_gatherable to ReadOnlyStorage #14280
• apollo_committer,starknet_committer: use blockifier's AccessedKeys #14252
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Refactor plus new dead-code helpers; behavior in fetch_all_patricia_paths is unchanged aside from shared address/root lookup.

Overview
Adds fetch_contract_storage_paths in trie_traversal.rs, mirroring create_storage_tries: when storage implements GatherableStorage, per-contract storage Patricia proofs are fetched via storage.gather and StoragePathsReadTask; otherwise the same work runs in a sequential loop.

Extracts get_address_and_storage_root so contract address + storage root resolution (including skipping missing/new/deleted contracts) is shared. fetch_all_patricia_paths in tree.rs now calls that helper instead of inlined logic.

The new entry points are #[allow(dead_code)] for now—the concurrent storage-path API is defined but not yet switched in at the main proof-fetch call site.

^{Reviewed by Cursor Bugbot for commit 72f6809. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/starknet_committer/src/db/trie_traversal.rs line 1001 at r1 (raw file):

        .await?;
        contracts_trie_storage_proofs.insert(contract_address, proof);
    }

Now I see that it's not new code.

Code quote:

    let mut contracts_trie_storage_proofs =
        HashMap::with_capacity(contract_storage_sorted_leaf_indices.len());

    for (idx, sorted_leaf_indices) in contract_storage_sorted_leaf_indices {
        let contract_address = try_node_index_into_contract_address(idx).unwrap_or_else(|_| {
            panic!(
                "Converting leaf NodeIndex to ContractAddress should succeed; failed to convert \
                 {idx:?}."
            )
        });

        // The contract address might not exist in the contracts trie in the following cases:
        // 1. We are looking at the previous tree and the contract is new.
        // 2. We are looking at the new tree and the contract is deleted (revert).
        // In either case, the storage trie of this contract is empty, so there is nothing to
        // prove regarding the contract storage.
        let Some(storage_root_hash) =
            contract_leaves.get(idx).map(|leaf| leaf.as_ref().storage_root_hash)
        else {
            continue;
        };

        let leaves = None;
        let proof = fetch_patricia_paths::<StorageLayout::DbLeaf, StorageLayout>(
            storage,
            storage_root_hash,
            *sorted_leaf_indices,
            leaves,
            &contract_address,
        )
        .await?;
        contracts_trie_storage_proofs.insert(contract_address, proof);
    }

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/db/trie_traversal.rs line 1000 at r1 (raw file):

        )
        .await?;
        contracts_trie_storage_proofs.insert(contract_address, proof);

Share code with impl StorageTask for StoragePathsReadTask.

Code quote:

        let leaves = None;
        let proof = fetch_patricia_paths::<StorageLayout::DbLeaf, StorageLayout>(
            storage,
            storage_root_hash,
            *sorted_leaf_indices,
            leaves,
            &contract_address,
        )
        .await?;
        contracts_trie_storage_proofs.insert(contract_address, proof);

[yoavGrs]

@yoavGrs reviewed 1 file.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on yoavGrs).

---

crates/starknet_committer/src/db/trie_traversal.rs line 1000 at r1 (raw file):

Previously, yoavGrs wrote…

Share code with impl StorageTask for StoragePathsReadTask.

There isn't much code to share, it only ends up increasing LOC. StoragePathsReadTask just calls fetch_patricia_paths, this function loops + does some input preparation.

[yoavGrs]

@yoavGrs resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).

---

crates/starknet_committer/src/db/trie_traversal.rs line 1001 at r1 (raw file):

Previously, yoavGrs wrote…

Now I see that it's not new code.

where is it from?

---

crates/starknet_committer/src/db/trie_traversal.rs line 989 at r1 (raw file):

        else {
            continue;
        };

to reduce boilerplate and keep the same docstring in one place, extract to a function and use twice

Suggestion:

        let Some((contract_address, storage_root_hash)) = get_address_and_storage_root(
            idx, contract_leaves
        ) else {
            continue;
        };

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).

---

crates/starknet_committer/src/db/trie_traversal.rs line 1001 at r1 (raw file):

Previously, dorimedini-starkware wrote…

where is it from?

ah, from fetch_all_patricia_paths?

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/starknet_committer/src/db/trie_traversal.rs line 989 at r1 (raw file):

Previously, dorimedini-starkware wrote…

to reduce boilerplate and keep the same docstring in one place, extract to a function and use twice

Done.

---

crates/starknet_committer/src/db/trie_traversal.rs line 1001 at r1 (raw file):

Previously, dorimedini-starkware wrote…

ah, from fetch_all_patricia_paths?

Ah now I see what you meant, this logic is changed a bit in the next PR anyway (I accidentally "fixed" it in this one, doesn't matter much)

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[graphite-app]

Merge activity

• Jun 8, 12:40 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
• Jun 8, 12:40 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).