starknet_committer: define StoragePathsReadTask#14281
Conversation
5d66469 to
3dd02d1
Compare
6209862 to
17d61f2
Compare
PR SummaryLow Risk Overview The task is generic over the same storage Reviewed by Cursor Bugbot for commit e7ae163. Bugbot is set up for automated code reviews on this repo. Configure here. |
17d61f2 to
4d43ae3
Compare
3dd02d1 to
1bb4a46
Compare
1bb4a46 to
c0762db
Compare
831d5cf to
6b3eb36
Compare
c0762db to
74043bf
Compare
6b3eb36 to
a3f03fc
Compare
227a428 to
9950a6c
Compare
5b37897 to
48b3a2f
Compare
d9a8e08 to
f36ecf8
Compare
9114559 to
5326f1b
Compare
f36ecf8 to
0f499ff
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).
crates/starknet_committer/src/db/trie_traversal.rs line 866 at r1 (raw file):
Layout: NodeLayoutFor<StarknetStorageValue> + Send + 'static, { type Output = TraversalResult<(ContractAddress, PreimageMap)>;
Why do you need the contract address in the output?
Code quote:
(ContractAddress, PreimageMap)
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on ArielElp).
crates/starknet_committer/src/db/trie_traversal.rs line 882 at r1 (raw file):
storage: &mut ReadsCollectorStorage<'storage, S>, ) -> Self::Output { let leaves = None;
When does it none and when not?
Code quote:
let leaves = None;
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on yoavGrs).
crates/starknet_committer/src/db/trie_traversal.rs line 866 at r1 (raw file):
Previously, yoavGrs wrote…
Why do you need the contract address in the output?
gather returns Vec<Task::Output>, we don't rely on ordering in both this task and the existing skeleton creation task
crates/starknet_committer/src/db/trie_traversal.rs line 882 at r1 (raw file):
Previously, yoavGrs wrote…
When does it none and when not?
None for storage/classes trie, not none for contracts trie
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 1 file and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
5326f1b to
e1d16c6
Compare
0f499ff to
7403c44
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
7403c44 to
d0cde67
Compare
e1d16c6 to
cf047d5
Compare
cf047d5 to
22fbbee
Compare
d0cde67 to
437c43d
Compare
437c43d to
e7ae163
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).

No description provided.