Skip to content

starknet_committer: define StoragePathsReadTask#14281

Merged
ArielElp merged 1 commit into
mainfrom
ariel/define_new_storage_task
Jun 8, 2026
Merged

starknet_committer: define StoragePathsReadTask#14281
ArielElp merged 1 commit into
mainfrom
ariel/define_new_storage_task

Conversation

@ArielElp

@ArielElp ArielElp commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@cursor

cursor Bot commented Jun 1, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Adds unused infrastructure only; no call sites or behavior changes to block commit or trie traversal yet.

Overview
Adds StoragePathsReadTask, a StorageTask companion to the existing TrieReadTask for per-contract storage tries. Where TrieReadTask builds an OriginalSkeletonTreeImpl via create_storage_trie, the new task runs fetch_patricia_paths (with leaves = None) and returns (ContractAddress, PreimageMap) for Patricia inner-node witnesses along paths to the given sorted leaf indices.

The task is generic over the same storage Layout and uses ContractAddress as the DB key context, matching other storage-trie reads. It is annotated with #[expect(dead_code)] because nothing dispatches it yet—likely groundwork for concurrent Patricia-path reads through GatherableStorage::gather, similar to concurrent skeleton trie creation.

Reviewed by Cursor Bugbot for commit e7ae163. Bugbot is set up for automated code reviews on this repo. Configure here.

@ArielElp ArielElp requested a review from yoavGrs June 1, 2026 12:39
@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch from 17d61f2 to 4d43ae3 Compare June 2, 2026 11:57
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from 3dd02d1 to 1bb4a46 Compare June 2, 2026 11:57
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from 1bb4a46 to c0762db Compare June 2, 2026 12:08
@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch from 831d5cf to 6b3eb36 Compare June 2, 2026 13:54
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from c0762db to 74043bf Compare June 2, 2026 13:54
@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch from 6b3eb36 to a3f03fc Compare June 2, 2026 16:02
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch 2 times, most recently from 227a428 to 9950a6c Compare June 2, 2026 17:21
@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch 2 times, most recently from 5b37897 to 48b3a2f Compare June 3, 2026 11:07
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch 3 times, most recently from d9a8e08 to f36ecf8 Compare June 3, 2026 15:17
@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch 2 times, most recently from 9114559 to 5326f1b Compare June 3, 2026 15:52
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from f36ecf8 to 0f499ff Compare June 3, 2026 15:52

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).


crates/starknet_committer/src/db/trie_traversal.rs line 866 at r1 (raw file):

    Layout: NodeLayoutFor<StarknetStorageValue> + Send + 'static,
{
    type Output = TraversalResult<(ContractAddress, PreimageMap)>;

Why do you need the contract address in the output?

Code quote:

(ContractAddress, PreimageMap)

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs made 1 comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on ArielElp).


crates/starknet_committer/src/db/trie_traversal.rs line 882 at r1 (raw file):

        storage: &mut ReadsCollectorStorage<'storage, S>,
    ) -> Self::Output {
        let leaves = None;

When does it none and when not?

Code quote:

let leaves = None;

@ArielElp ArielElp left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielElp made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on yoavGrs).


crates/starknet_committer/src/db/trie_traversal.rs line 866 at r1 (raw file):

Previously, yoavGrs wrote…

Why do you need the contract address in the output?

gather returns Vec<Task::Output>, we don't rely on ordering in both this task and the existing skeleton creation task


crates/starknet_committer/src/db/trie_traversal.rs line 882 at r1 (raw file):

Previously, yoavGrs wrote…

When does it none and when not?

None for storage/classes trie, not none for contracts trie

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@yoavGrs yoavGrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs reviewed 1 file and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp force-pushed the ariel/move_as_gatherable_to_read_only_storage branch from 5326f1b to e1d16c6 Compare June 7, 2026 07:57
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from 0f499ff to 7403c44 Compare June 7, 2026 07:57

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp changed the base branch from ariel/move_as_gatherable_to_read_only_storage to graphite-base/14281 June 7, 2026 11:46
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from 7403c44 to d0cde67 Compare June 7, 2026 12:09
@ArielElp ArielElp force-pushed the graphite-base/14281 branch from e1d16c6 to cf047d5 Compare June 7, 2026 12:09
@ArielElp ArielElp changed the base branch from graphite-base/14281 to ariel/move_as_gatherable_to_read_only_storage June 7, 2026 12:09
@ArielElp ArielElp changed the base branch from ariel/move_as_gatherable_to_read_only_storage to graphite-base/14281 June 7, 2026 12:13
@ArielElp ArielElp force-pushed the graphite-base/14281 branch from cf047d5 to 22fbbee Compare June 7, 2026 12:17
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from d0cde67 to 437c43d Compare June 7, 2026 12:17
@ArielElp ArielElp changed the base branch from graphite-base/14281 to ariel/move_as_gatherable_to_read_only_storage June 7, 2026 12:17
@ArielElp ArielElp changed the base branch from ariel/move_as_gatherable_to_read_only_storage to main June 7, 2026 14:51
@ArielElp ArielElp force-pushed the ariel/define_new_storage_task branch from 437c43d to e7ae163 Compare June 8, 2026 11:58

@dorimedini-starkware dorimedini-starkware left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 9 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@ArielElp ArielElp added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit e0b7076 Jun 8, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants