apollo_committer,starknet_committer: use blockifier's AccessedKeys

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-05-28T15:19:42Z
• Started at 2026-05-28T15:29:34Z
• Started at 2026-05-31T13:47:29Z
• Started at 2026-05-31T13:48:02Z
• Started at 2026-05-31T14:41:32Z
• Started at 2026-05-31T17:03:53Z
• Started at 2026-06-01T08:24:53Z
• Started at 2026-06-03T15:52:49Z
• Started at 2026-06-04T08:15:30Z
• Started at 2026-06-07T07:57:58Z

[ArielElp]

• starknet_committer: fetch patricia paths concurrently #14283
• starknet_committer: define fetch_contract_storage_paths_concurrently #14282
• starknet_committer: define StoragePathsReadTask #14281
• starknet_patricia_storage: move is_gatherable to ReadOnlyStorage #14280
• apollo_committer,starknet_committer: use blockifier's AccessedKeys #14252 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Changes the OS/committer witness input shape across apollo_committer, starknet_committer, and starknet_os; behavior should be equivalent but any mismatch in key sets would affect Patricia digests and proofs.

Overview
Unifies trie witness / Patricia path collection on blockifier’s AccessedKeys instead of ad‑hoc class_hashes, contract lists, and per-contract storage maps (or StateChangesKeys in the OS).

starknet_committer now depends on blockifier and builds LeavesRequest via From<&AccessedKeys>, with sorting moved to LeavesRequest::sorted(). fetch_previous_and_new_patricia_paths takes a single &AccessedKeys. apollo_committer’s read_paths_and_commit_block uses that path directly for digest + witnesses.

blockifier adds From<StateChangesKeys> for AccessedKeys. starknet_os StateCommitmentInfos::new and the transaction prover pass AccessedKeys (or .into() from state-change keys) and drop the local StateChangesKeys → Patricia wrapper. Flow tests pass &accessed_keys without converting to StateChangesKeys first.

^{Reviewed by Cursor Bugbot for commit 0d7ef4c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 50bbdd5. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on ArielElp and yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on ArielElp and yoavGrs).

[ArielElp]

@ArielElp made 3 comments.
Reviewable status: 4 of 10 files reviewed, 3 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/apollo_committer/src/committer.rs line 35 at r2 (raw file):

Previously, dorimedini-starkware wrote…

looks like this should be gated

Not needed actually

---

crates/starknet_committer/Cargo.toml line 18 at r2 (raw file):

Previously, dorimedini-starkware wrote…

right? not needed if no os inputs?

Done.

---

crates/starknet_os/src/commitment_infos.rs line 188 at r2 (raw file):

Previously, dorimedini-starkware wrote…

can't this function just be deleted now?

Agreed, note this induces using os_input in the starknet_committer dep of starknet_os, in order for fetch_previous_and_new_patricia_paths to be available there (now that blockifier and AccessedKeys are optional)

[dorimedini-starkware]

@dorimedini-starkware reviewed 6 files and all commit messages, made 2 comments, and resolved 2 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).

---

crates/starknet_os/src/commitment_infos.rs line 188 at r2 (raw file):

Previously, ArielElp wrote…

Agreed, note this induces using os_input in the starknet_committer dep of starknet_os, in order for fetch_previous_and_new_patricia_paths to be available there (now that blockifier and AccessedKeys are optional)

ah... so, revert. not worth the risk of activating the feature in production code.
you can consider adding an os_input feature to starknet_os, which - if active - activates the starknet_committer's feature

---

crates/starknet_os/Cargo.toml line 65 at r5 (raw file):

starknet-types-core.workspace = true
starknet_api.workspace = true
starknet_committer = { workspace = true, features = ["os_input"] }

not in production deps!

Code quote:

starknet_committer = { workspace = true, features = ["os_input"] }

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

crates/starknet_os/Cargo.toml line 65 at r5 (raw file):

Previously, dorimedini-starkware wrote…

not in production deps!

Done.

---

crates/starknet_os/src/commitment_infos.rs line 188 at r2 (raw file):

Previously, dorimedini-starkware wrote…

ah... so, revert. not worth the risk of activating the feature in production code.
you can consider adding an os_input feature to starknet_os, which - if active - activates the starknet_committer's feature

Then I think we must revert making blockifier optional in starknet_committer:

1. starknet_os needs to call fetch_previous_and_new_patricia_paths, either with the above (useless) wrapper or directly
2. this function only exists in starknet_committer under os_input, because of the blockifier type

So I think that either we accept os_input in starknet_committer or keep blockifier non optional

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).