starknet_transaction_prover: add prover input validation unit tests#14047
starknet_transaction_prover: add prover input validation unit tests#14047avi-starkware wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview Prover test hooks: Test doubles: Coverage: Rejects pending blocks, Reviewed by Cursor Bugbot for commit 6141678. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62bd425. Configure here.
55fbb37 to
a142608
Compare
62bd425 to
e7ccb94
Compare
a142608 to
ad656d1
Compare
e7ccb94 to
0523284
Compare
ad656d1 to
7a2f45c
Compare
0523284 to
3275e20
Compare
3275e20 to
63d5c0b
Compare
7a2f45c to
257e70a
Compare
Adds unit tests for VirtualSnosProver input validation: pending block rejection, DeployAccount rejection, proof/proof_facts field rejection, non-zero fee field rejection (with the validation knob respected when disabled), and a happy-path test that asserts a valid invoke reaches the runner. Adds two test runners — UnreachableRunner (panics on invocation, for tests where validation must reject the input) and FailingRunner (returns an error, for tests that must verify the runner is reached without needing a real node).
257e70a to
6cb82a2
Compare
63d5c0b to
6141678
Compare


Adds unit tests for VirtualSnosProver input validation: pending block
rejection, DeployAccount rejection, proof/proof_facts field rejection,
non-zero fee field rejection (with the validation knob respected when
disabled), and a happy-path test that asserts a valid invoke reaches
the runner.
Adds two test runners — UnreachableRunner (panics on invocation, for
tests where validation must reject the input) and FailingRunner (returns
an error, for tests that must verify the runner is reached without
needing a real node).