Skip to content

starknet_transaction_prover: add committer utils unit tests#14046

Open
avi-starkware wants to merge 1 commit into
avi/privacy/request-body-size-tests-v2from
avi/privacy/committer-utils-tests-v2
Open

starknet_transaction_prover: add committer utils unit tests#14046
avi-starkware wants to merge 1 commit into
avi/privacy/request-body-size-tests-v2from
avi/privacy/committer-utils-tests-v2

Conversation

@avi-starkware

Copy link
Copy Markdown
Collaborator

Covers state_maps_to_committer_state_diff (empty / nonces / storage /
compiled class hashes) and validate_virtual_os_state_diff (valid storage,
valid nonce, and rejection of storage deletion / contract deployment /
contract declaration).

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@avi-starkware avi-starkware marked this pull request as ready for review May 17, 2026 15:42
@cursor

cursor Bot commented May 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Test-only changes with no production logic modifications.

Overview
Adds committer_utils_test and wires it in running.rs so the existing committer helpers are covered by unit tests.

validate_virtual_os_state_diff is exercised with rstest: empty diffs, non-zero storage, and nonce updates should pass; zero storage (deletion), address_to_class_hash (deployments), and class_hash_to_compiled_class_hash (declarations) should fail with ProofProviderError::InvalidStateDiff messages matching expected substrings.

state_maps_to_committer_state_diff is tested for an empty StateMaps, and for preserving nonces, per-contract storage keys/values, and compiled class hash mapping into the committer StateDiff shape.

Reviewed by Cursor Bugbot for commit 6cb82a2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

Artifacts upload workflows:

Covers state_maps_to_committer_state_diff (empty / nonces / storage /
compiled class hashes) and validate_virtual_os_state_diff (valid storage,
valid nonce, and rejection of storage deletion / contract deployment /
contract declaration).
@avi-starkware avi-starkware changed the base branch from main-v0.14.3 to graphite-base/14046 June 7, 2026 11:45
@avi-starkware avi-starkware force-pushed the avi/privacy/committer-utils-tests-v2 branch from 257e70a to 6cb82a2 Compare June 7, 2026 11:46
@avi-starkware avi-starkware changed the base branch from graphite-base/14046 to avi/privacy/request-body-size-tests-v2 June 7, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants