Skip to content

Suggestion: Replace [Yb],[Lu] placeholders with '*' in SMILES strings of fragments #7

@madiha1ahmed

Description

@madiha1ahmed

Hello,

I've been working with the mol_utils.py module and noticed that the code uses [Yb] and [Lu] as placeholders or connectors of fragments in SMILES strings. While this approach is unique, it might be more intuitive and consistent with common practices in cheminformatics to use the * wildcard as a placeholder.

Reasons for the suggestion:

  1. The * wildcard is a widely recognized placeholder in SMILES notation.
  2. Using [Yb] and [Lu] might lead to confusion as these are valid representations for the Ytterbium and Lutetium elements respectively.
  3. I've encountered some issues when processing the SMILES strings with other tools due to these placeholders.

Here's a simple example of how the replacement might look:
Original: F[Yb]
Suggested: F*

I believe making this change would enhance the module's compatibility and user-friendliness. I hope you'll consider this suggestion. Thank you for your great work on this project!

Best regards,
Madiha

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions