Skip to content

Tons of python warnings, plus how to actually run this? #9

Description

@fdmanana

Running run-fxmark.sh, I get many warnings:

root 17:59:52 /home/fdmanana/git/hub/fxmark (master)> ./bin/run-fxmark.py
./bin/run-fxmark.py:243: SyntaxWarning: "is" with a literal. Did you mean "=="?
if ncore is 0:
./bin/run-fxmark.py:281: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:338: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:343: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:347: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:360: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:364: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:369: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:373: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if p.returncode is not 0:
./bin/run-fxmark.py:427: SyntaxWarning: "is" with a literal. Did you mean "=="?
directio = '1' if dio is "directio" else '0'
./bin/run-fxmark.py:429: SyntaxWarning: "is" with a literal. Did you mean "=="?
if directio is '1':
./bin/run-fxmark.py:430: SyntaxWarning: "is" with a literal. Did you mean "=="?
if fs is "tmpfs":
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%% WARNING! WARNING! WARNING! WARNING! WARNING!
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
All data in /dev/sdj, /dev/sdj, /dev/sdj and /dev/loop1 will be deleted. Is it ok? [Y,N]: Y
Are you sure? [Y,N]: Y
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

SYSTEM = Linux debian9 5.19.0-rc1-btrfs-next-120 #1 SMP PREEMPT_DYNAMIC Wed Jun 8 11:07:10 WEST 2022 x86_64 GNU/Linux

DISK_SIZE = 32G

DURATION = 30s

DIRECTIO = bufferedio,directio

MEDIA_TYPES = hdd

FS_TYPES = btrfs

BENCH_TYPES = DWAL,DWOL,DWOM,DWSL,MWRL,MWRM,MWCL,MWCM,MWUM,MWUL,DWTL,filebench_varmail,filebench_oltp,filebench_fileserver,dbench_client,MRPL,MRPM,MRPH,MRDM,MRDL,DRBH,DRBM,DRBL

NCORES = 1,2,3,4,5,6,7,8

CORE_SEQ = 0,1,2,3,4,5,6,7

MODEL_NAME = Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz

PHYSICAL_CHIPS = 8

CORE_PER_CHIP = 1

SMT_LEVEL = 1

NUM_TEST_CONF = 0

/home/fdmanana/git/hub/fxmark/bin/perfmon.py:230: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if len(sys.argv) is not 2:
root 17:59:59 /home/fdmanana/git/hub/fxmark (master)> echo $?
0

More importantly, running fxmark like that did nothing, didn't test anything, it finishes immediately.
I edited run-fxmark.py like this:


> diff --git a/bin/run-fxmark.py b/bin/run-fxmark.py
> index a5fe0aa..49ffb1e 100755
> --- a/bin/run-fxmark.py
> +++ b/bin/run-fxmark.py
> @@ -24,10 +24,14 @@ def catch_ctrl_C(sig, frame):
>  
>  class Runner(object):
>      # media path
> -    LOOPDEV = "/dev/loopX"
> -    NVMEDEV = "/dev/nvme0n1pX"
> -    HDDDEV  = "/dev/sdX"
> -    SSDDEV  = "/dev/sdY"
> +    # LOOPDEV = "/dev/loopX"
> +    # NVMEDEV = "/dev/nvme0n1pX"
> +    # HDDDEV  = "/dev/sdj"
> +    # SSDDEV  = "/dev/sdY"
> +    LOOPDEV = "/dev/loop1"
> +    NVMEDEV = "/dev/sdj"
> +    HDDDEV  = "/dev/sdj"
> +    SSDDEV  = "/dev/sdj"
>  
>      # test core granularity
>      CORE_FINE_GRAIN   = 0
> @@ -48,14 +52,16 @@ class Runner(object):
>          self.DISK_SIZE     = "32G"
>          self.DURATION      = 30 # seconds
>          self.DIRECTIOS     = ["bufferedio", "directio"]  # enable directio except tmpfs -> nodirectio 
> -        self.MEDIA_TYPES   = ["ssd", "hdd", "nvme", "mem"]
> +#        self.MEDIA_TYPES   = ["ssd", "hdd", "nvme", "mem"]
> +        self.MEDIA_TYPES   = ["hdd"]
>  #        self.FS_TYPES      = [
> -        self.FS_TYPES      = ["tmpfs",
> -                              "ext4", "ext4_no_jnl",
> -                              "xfs",
> -                              "btrfs", "f2fs",
> -                              # "jfs", "reiserfs", "ext2", "ext3",
> -        ]
> +        # self.FS_TYPES      = ["tmpfs",
> +        #                       "ext4", "ext4_no_jnl",
> +        #                       "xfs",
> +        #                       "btrfs", "f2fs",
> +        #                       # "jfs", "reiserfs", "ext2", "ext3",
> +        # ]
> +        self.FS_TYPES      = ["btrfs"]
>          self.BENCH_TYPES   = [
>              # write/write
>              "DWAL",
> 

What am I doing wrong?
Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions