PageHeroHighlights - Skills, Tests and Stories updated

Author: srcdev

.claude/skills/components/page-hero-highlights.md

@@ -17,8 +17,8 @@ The layout uses a 4-row CSS Grid with `subgrid` — no `translate`, negative mar
 | `tag`                   | `"div" \| "section" \| "main"`                                      | `"div"`     | Root element tag                                                                                                                |
 | `highlightsEqualWidths` | `boolean`                                                           | `false`     | Equal-width grid columns for highlight items                                                                                    |
 | `highlightsJustify`     | `"start" \| "center" \| "end" \| "space-between" \| "space-around"` | `"start"`   | Alignment of highlight items along the main axis                                                                                |
-| `maxWidth`              | `string`                                                            | `undefined` | Cap the central content column (e.g. `"1064px"`). Gutters grow to enforce the constraint; below this width they hold at `16px`. |
-| `contentAlign`          | `"start" \| "center"`                                               | `"center"`  | When `maxWidth` is set: `"center"` grows gutters equally; `"start"` pins content to the left with a fixed `16px` left gutter.   |
+| `maxWidth`              | `boolean`                                                           | `false`     | When `true`, caps the central column at `--max-width` (default `1064px`). Gutters grow responsively to enforce the constraint. |
+| `contentAlign`          | `"start" \| "center"`                                               | `"center"`  | When `maxWidth` is `true`: `"center"` grows gutters equally; `"start"` pins content to the left with a fixed left gutter.      |
 | `contentPanel`          | `boolean`                                                           | `true`      | When `true`, renders a decorative panel behind the content slot and offsets the highlights strip. Set to `false` for a flat layout with no backdrop. |
 | `highlightTitleBaseline`| `boolean`                                                           | `false`     | When `true`, fixes the highlight title row to a set height so titles align at a common baseline. Override `--highlight-title-height` to tune. |
 | `styleClassPassthrough` | `string \| string[]`                                                | `[]`        | Extra classes on the root element                                                                                               |
@@ -66,7 +66,7 @@ Each slot accepts any content, but these library components are natural fits:
 Example with `HeroText` in the header slot:
 
 ```vue
-<PageHeroHighlights tag="section" max-width="1064px">
+<PageHeroHighlights tag="section" :max-width="true">
   <template #header="{ headingId }">
     <HeroText :heading-id="headingId" text="Welcome back" accent-text="Simon" />
   </template>
@@ -106,11 +106,13 @@ Located at: `app/components/04.templates/page-hero-highlights/PageHeroHighlights
 
 ### CSS tokens
 
-| Token              | Default  | Description                              |
-| ------------------ | -------- | ---------------------------------------- |
-| `--phh-padding-block` | `1.6rem` | Block padding on the header              |
-| `--phh-gap`        | `1.6rem` | Gap between `#start` and `#end` areas    |
-| `--phh-end-gap`    | `0.8rem` | Gap between items within `#end`          |
+| Token                      | Default          | Description                                          |
+| -------------------------- | ---------------- | ---------------------------------------------------- |
+| `--phh-padding-block-mobile`  | `1.6rem 3.2rem`  | Block padding (start end) at mobile widths           |
+| `--phh-padding-block-tablet`  | `2.4rem 4.8rem`  | Block padding (start end) at ≥768px                  |
+| `--phh-padding-block-desktop` | `3.2rem 6.4rem`  | Block padding (start end) at ≥1024px                 |
+| `--phh-gap`                   | `1.6rem`         | Gap between `#start` and `#end` areas                |
+| `--phh-end-gap`               | `0.8rem`         | Gap between items within `#end`                      |
 
 ### Usage
 
@@ -170,17 +172,26 @@ By default, highlight items size to their content (`flex-wrap`). Pass `:highligh
 
 ## Constraining the central column width
 
-Pass `max-width` to cap the content column. The gutters grow to enforce it — full-bleed backgrounds are unaffected and `subgrid` continues to work. Use `content-align` to pin to the left or centre:
+Pass `:max-width="true"` to cap the content column at `--max-width` (default `1064px`). The gutters grow responsively to enforce it — full-bleed backgrounds are unaffected and `subgrid` continues to work. Use `content-align` to pin to the left or centre:
 
 ```vue
-<!-- Centred, capped at 1064px -->
-<PageHeroHighlights max-width="1064px" content-align="center">...</PageHeroHighlights>
+<!-- Centred, capped at --max-width (1064px) -->
+<PageHeroHighlights :max-width="true" content-align="center">...</PageHeroHighlights>
 
-<!-- Left-pinned, capped at 1064px (right side takes remaining space) -->
-<PageHeroHighlights max-width="1064px" content-align="start">...</PageHeroHighlights>
+<!-- Left-pinned (right side takes remaining space) -->
+<PageHeroHighlights :max-width="true" content-align="start">...</PageHeroHighlights>
 ```
 
-See [css-grid-max-width-gutters.md](../css-grid-max-width-gutters.md) for the full pattern explanation.
+The maximum width value and gutter sizes are all CSS tokens — override them via `styleClassPassthrough` if you need different values:
+
+```css
+.my-page-hero {
+  --max-width: 1200px;
+  --page-hero-highlights-gutter-desktop: 48px;
+}
+```
+
+See [css-grid-max-width-gutters.md](../css-grid-max-width-gutters.md) for the underlying pattern explanation.
 
 ## Local style override scaffold
 
@@ -199,6 +210,12 @@ See [component-local-style-override.md](../component-local-style-override.md) fo
    ─────────────────────────────────────────────────────────────────── */
 .page-hero-highlights {
   &.my-page-hero {
+    /* Grid layout */
+    /* --max-width: 1064px; */
+    /* --page-hero-highlights-gutter-mobile: 16px; */
+    /* --page-hero-highlights-gutter-tablet: 40px; */
+    /* --page-hero-highlights-gutter-desktop: 32px; */
+
     /* Header zone */
     /* --header-row-background-colour: darkblue; */
 
@@ -239,8 +256,6 @@ See [component-local-style-override.md](../component-local-style-override.md) fo
 </style>
 ```
 
-> **Note:** The minimum gutter width (`16px`) and layout behaviour are not overridable via CSS custom properties. Use the `max-width` and `content-align` props to control column constraints.
-
 ## Grid structure (reference)
 
 ```text
@@ -254,6 +269,8 @@ row4: page content (never underflows highlights)
 `.header-row` spans cols 1–3, rows 1–2 (edge-to-edge bg). `.header-slot` is placed in row 1 only.
 `.content-row` spans cols 1–3, rows 3–4 (bg fills behind highlights; `.content-slot` is placed in row 4 only). The decorative border behind `.content-slot` is rendered via `.content-row:before` — there is no separate DOM element for it.
 
+Grid columns are determined entirely by CSS — no `v-bind`. The `maxWidth` and `contentAlign` props add CSS classes (`max-width`, `start`, `center`) which select the appropriate `grid-template-columns` rule.
+
 ## Layout pitfall: do not use `grid-template-rows: subgrid` inside `.highlights-row`
 
 The `.highlights-row` element spans rows 2–3 of the parent grid (the "straddle"). If you add an inner grid to `.highlights-row` (e.g. to extend `equal-widths` behaviour) and include `grid-template-rows: subgrid`, auto-placed items will only occupy row 1 of the subgrid (= parent row 2). Parent row 3 collapses to 0-height, destroying the straddle effect — `.content-row` appears immediately below the highlights instead of overlapping it.
@@ -280,5 +297,5 @@ The `.highlights-row` element spans rows 2–3 of the parent grid (the "straddle
 - Component is auto-imported in Nuxt — no import needed.
 - Lives in `app/components/04.templates/page-hero-highlights/`.
 - Storybook title: `"Templates/PageHeroHighlights"`.
-- **Minimum gutter is fixed at `16px`** — it is baked into the `gridColumns` computed and cannot be overridden by a CSS custom property. If a consumer needs a different minimum (e.g. `24px`), it requires a prop or a fork of the component.
-- **`contentAlign` has no effect without `maxWidth`** — both sides always hold `16px` when `maxWidth` is not set.
+- **`contentAlign` has no effect when `maxWidth` is `false`** — both gutters hold their responsive default.
+- **Gutter sizes are CSS tokens** — `--page-hero-highlights-gutter-mobile/tablet/desktop` are all overridable. The responsive switching between them (via `@container`) is handled internally and cannot be overridden.

.claude/skills/css-grid-max-width-gutters.md

@@ -31,10 +31,47 @@ Left gutter stays fixed, content column is capped at `MAX_WIDTH`, remaining spac
 
 ## In Vue with a prop
 
+### Option A — CSS tokens + class selectors (preferred when max-width is a fixed design value)
+
+When the max-width and gutter values are fixed design tokens (not arbitrary consumer strings), express the logic entirely in CSS using a boolean `maxWidth` prop that adds a class:
+
+```ts
+interface Props {
+  maxWidth?: boolean;
+  contentAlign?: "start" | "center";
+}
+```
+
+```css
+.component {
+  --max-width: 1064px;
+  --gutter: 16px;
+
+  display: grid;
+
+  &.max-width {
+    grid-template-columns: var(--gutter) 1fr var(--gutter);
+  }
+
+  &:not(.max-width) {
+    &.start {
+      grid-template-columns: var(--gutter) minmax(0, var(--max-width)) minmax(var(--gutter), 1fr);
+    }
+    &.center {
+      grid-template-columns: max(var(--gutter), (100% - var(--max-width)) / 2) 1fr
+        max(var(--gutter), (100% - var(--max-width)) / 2);
+    }
+  }
+}
+```
+
+Consumers can override `--max-width` and `--gutter` via `styleClassPassthrough` without touching the prop. This is the approach used by `PageHeroHighlights`.
+
+### Option B — computed string with `v-bind` (use when max-width is a dynamic consumer prop)
+
 Because `v-bind()` in `<style>` can't be nested inside CSS functions like `max()`, build the column string as a computed and bind the whole value:
 
 ```ts
-// Props
 interface Props {
   maxWidth?: string;        // e.g. "1064px"
   contentAlign?: "start" | "center";
@@ -45,7 +82,6 @@ const props = withDefaults(defineProps<Props>(), {
   contentAlign: "center",
 });
 
-// Computed column string
 const gridColumns = computed(() => {
   if (!props.maxWidth) return "16px 1fr 16px";
   if (props.contentAlign === "start") return `16px minmax(0, ${props.maxWidth}) 1fr`;

app/components/04.templates/page-hero-highlights/PageHeroHighlights.vue

@@ -44,12 +44,6 @@ const props = withDefaults(defineProps<Props>(), {
   styleClassPassthrough: () => [],
 });
 
-// const gridColumns = computed(() => {
-//   if (!props.maxWidth) return "16px 1fr 16px";
-//   if (props.contentAlign === "start") return `16px minmax(0, ${props.maxWidth}) minmax(16px, 1fr)`;
-//   return `max(16px, (100% - ${props.maxWidth}) / 2) 1fr max(16px, (100% - ${props.maxWidth}) / 2)`;
-// });
-
 const { headingId, ariaLabelledby } = useAriaLabelledById(() => props.tag);
 const componentClasses = computed(() => ({
   "highlight-title-baseline": props.highlightTitleBaseline,

app/components/04.templates/page-hero-highlights/stories/PageHeroHighlights.stories.ts

@@ -6,7 +6,7 @@ type StoryArgs = {
   tag?: "div" | "section" | "main";
   highlightsEqualWidths?: boolean;
   highlightsJustify?: "start" | "center" | "end" | "space-between" | "space-around";
-  maxWidth?: string;
+  maxWidth?: boolean;
   contentAlign?: "start" | "center";
   contentPanel?: boolean;
   highlightTitleBaseline?: boolean;
@@ -35,10 +35,9 @@ const meta: Meta<StoryArgs> = {
       description: "Justification of highlight items along the main axis",
     },
     maxWidth: {
-      control: { type: "select" },
-      options: ["", "600px", "800px", "1024px", "1064px", "1200px", "1440px"],
+      control: "boolean",
       description:
-        "Max width of the central content column. Gutters grow to enforce the constraint; below this width they hold at 16px.",
+        "When true, caps the central column at --max-width (default 1064px). Gutters grow responsively to enforce the constraint. Override --max-width via styleClassPassthrough to change the cap value.",
     },
     contentAlign: {
       control: { type: "inline-radio" },
@@ -78,7 +77,7 @@ const meta: Meta<StoryArgs> = {
     tag: "div",
     highlightsEqualWidths: false,
     highlightsJustify: "start",
-    maxWidth: "",
+    maxWidth: false,
     contentAlign: "center",
     contentPanel: true,
     highlightTitleBaseline: false,
@@ -119,6 +118,12 @@ All layout and visual properties are customisable via CSS custom properties. Set
 
 \`\`\`css
 .page-hero-highlights {
+  /* Grid layout */
+  --max-width: 1064px;
+  --page-hero-highlights-gutter-mobile: 16px;
+  --page-hero-highlights-gutter-tablet: 40px;
+  --page-hero-highlights-gutter-desktop: 32px;
+
   /* Header zone */
   --header-row-background-colour: darkblue;
 
@@ -196,6 +201,12 @@ All layout and visual properties are customisable via CSS custom properties. Set
    ─────────────────────────────────────────────────────────────────── */
 .page-hero-highlights {
 
+  /* Grid layout */
+  --max-width: 1064px;
+  --page-hero-highlights-gutter-mobile: 16px;
+  --page-hero-highlights-gutter-tablet: 40px;
+  --page-hero-highlights-gutter-desktop: 32px;
+
   /* Header zone */
   --header-row-background-colour: darkblue;
 
@@ -330,10 +341,10 @@ export const NoSlotContent: Story = {
   }),
 };
 
-/** Max width centered — content column capped at 800px with equal growing gutters either side. */
+/** Max width centered — content column capped at --max-width (1064px) with equal growing gutters either side. */
 export const MaxWidthCentered: Story = {
   name: "Max Width — Centered",
-  args: { maxWidth: "800px", contentAlign: "center" },
+  args: { maxWidth: true, contentAlign: "center" },
   render: (args: StoryArgs) => ({
     components: { PageHeroHighlights },
     setup() {
@@ -343,7 +354,7 @@ export const MaxWidthCentered: Story = {
       <PageHeroHighlights v-bind="componentArgs" :style="bgStyles">
         <template #header>
           <p class="page-heading-1">Dashboard</p>
-          <p class="page-body-normal">Content column is capped at 800px — gutters grow equally on both sides.</p>
+          <p class="page-body-normal">Content column is capped at --max-width (1064px by default) — gutters grow equally on both sides.</p>
         </template>
 
         <template #highlights>
@@ -370,10 +381,10 @@ export const MaxWidthCentered: Story = {
   }),
 };
 
-/** Max width start — content column capped at 800px, pinned to the left with a fixed 16px gutter. */
+/** Max width start — content column capped at --max-width (1064px), pinned to the left. */
 export const MaxWidthStart: Story = {
   name: "Max Width — Start",
-  args: { maxWidth: "800px", contentAlign: "start" },
+  args: { maxWidth: true, contentAlign: "start" },
   render: (args: StoryArgs) => ({
     components: { PageHeroHighlights },
     setup() {
@@ -383,7 +394,7 @@ export const MaxWidthStart: Story = {
       <PageHeroHighlights v-bind="componentArgs" :style="bgStyles">
         <template #header>
           <p class="page-heading-1">Dashboard</p>
-          <p class="page-body-normal">Content column is capped at 800px, aligned to the start — right side takes the remaining space.</p>
+          <p class="page-body-normal">Content column is capped at --max-width (1064px by default), aligned to the start — right side takes the remaining space.</p>
         </template>
 
         <template #highlights>

app/components/04.templates/page-hero-highlights/tests/PageHeroHighlights.spec.ts

@@ -168,39 +168,30 @@ describe("PageHeroHighlights", () => {
     expect(el.classes()).toContain("another-class");
   });
 
-  describe("gridColumns", () => {
-    interface ComponentInstance {
-      gridColumns: string;
-    }
-
-    it("defaults to fixed 16px gutters with no maxWidth", async () => {
+  describe("grid layout classes", () => {
+    it("applies center class by default", async () => {
       const wrapper = await mountSuspended(PageHeroHighlights);
-      const vm = wrapper.vm as unknown as ComponentInstance;
-      expect(vm.gridColumns).toBe("16px 1fr 16px");
+      expect(wrapper.find(".page-hero-highlights").classes()).toContain("center");
     });
 
-    it("returns centered max-width columns when maxWidth is set and contentAlign is center", async () => {
-      const wrapper = await mountSuspended(PageHeroHighlights, {
-        props: { maxWidth: "1064px", contentAlign: "center" },
-      });
-      const vm = wrapper.vm as unknown as ComponentInstance;
-      expect(vm.gridColumns).toBe("max(16px, (100% - 1064px) / 2) 1fr max(16px, (100% - 1064px) / 2)");
+    it("does not apply max-width class by default", async () => {
+      const wrapper = await mountSuspended(PageHeroHighlights);
+      expect(wrapper.find(".page-hero-highlights").classes()).not.toContain("max-width");
     });
 
-    it("returns start-aligned columns when maxWidth is set and contentAlign is start", async () => {
+    it("applies max-width class when maxWidth is true", async () => {
       const wrapper = await mountSuspended(PageHeroHighlights, {
-        props: { maxWidth: "1064px", contentAlign: "start" },
+        props: { maxWidth: true },
       });
-      const vm = wrapper.vm as unknown as ComponentInstance;
-      expect(vm.gridColumns).toBe("16px minmax(0, 1064px) minmax(16px, 1fr)");
+      expect(wrapper.find(".page-hero-highlights").classes()).toContain("max-width");
     });
 
-    it("ignores contentAlign when maxWidth is not set", async () => {
+    it("applies start class when contentAlign is start", async () => {
       const wrapper = await mountSuspended(PageHeroHighlights, {
         props: { contentAlign: "start" },
       });
-      const vm = wrapper.vm as unknown as ComponentInstance;
-      expect(vm.gridColumns).toBe("16px 1fr 16px");
+      expect(wrapper.find(".page-hero-highlights").classes()).toContain("start");
+      expect(wrapper.find(".page-hero-highlights").classes()).not.toContain("center");
     });
   });
 });

app/components/04.templates/page-hero-highlights/tests/__snapshots__/PageHeroHighlights.spec.ts.snap

@@ -1,7 +1,7 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
 exports[`PageHeroHighlights > renders correct HTML structure 1`] = `
-"<div class="page-hero-highlights has-content-panel">
+"<div class="page-hero-highlights center has-content-panel">
   <div class="header-row">
     <div class="header-slot">
       <h1>Page Title</h1>