Add configurable timeout support to JmsHealthIndicator

[marko-modsching-bison]

The mentioned HealthIndicator uses a fixed time-interval of 5 seconds. In some cases it might be important to overwrite this value. For example when the service-broker has some pressure and can't respond within 5 seconds. Or the health-intervalls are configured to fire too often (many parallel pods with corresponding health checks). Thus the value should be configurable.

[snicoll]

A timeout was introduced by #36694, which felt like a good idea to me. There isn't a great way to reduce the existing code as it would mean copy/pasting it at the moment.

[GollapudiSrikanth]

I'd be happy to help with this enhancement and the preferred approach is agreed. Please let me know if you'd like me to work on it.

[Manjeet2001]

I'd like to work on this enhancement. My proposed approach is:

JmsHealthIndicator: Accept a Duration timeout in the constructor and pass it to this.latch.await(timeout.toMillis(), TimeUnit.MILLISECONDS) instead of the hardcoded 5 seconds.

JmsHealthIndicatorProperties: Create a new configuration properties class in org.springframework.boot.jms.autoconfigure.health to bind management.health.jms.timeout (defaulting to 5s).

JmsHealthContributorAutoConfiguration: Enable the new properties class, inject it, and update the constructor to forward the timeout value.

Please let me know if this approach looks good.

[snicoll]

@Manjeet2001 as you can see in the comment above yours, someone already offered to contribute. Thank you, in any case.

[snicoll]

@GollapudiSrikanth if you still
want to contribute please let me know so that I can assign you this one. As for the approach, adding the timeout as a constructor argument is the plan.

[GollapudiSrikanth]

Hi @snicoll
Please assign this to me, will implement as suggested!!

[snicoll]

Closing in favor of PR #50957 - Thanks @GollapudiSrikanth