Skip to content

Commit cdf1ccb

Browse files
authored
Add favicon links using apos.asset.url in extraHead block (#201)
Changes: - Added favicon.ico to modules/asset/public/favicon/ - Updated website/views/layout.html to include favicon <link> tags inside the extraHead block - Used apos.asset.url() to generate correct asset URLs for the favicon
1 parent 5f7322c commit cdf1ccb

2 files changed

Lines changed: 49 additions & 37 deletions

File tree

33.7 KB
Binary file not shown.

website/views/layout.html

Lines changed: 49 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,50 @@
1-
{# Automatically extends the right outer layout and also handles AJAX situations
2-
#} {% extends data.outerLayout %} {% import 'fragments/fragments.html' as
3-
fragments %} {% set title = data.piece.title or data.page.title %} {% block
4-
title %} {{ title }} {% if not title %} {{ apos.log('Looks like you forgot to
5-
override the title block in a template that does not have access to an
6-
Apostrophe page or piece.') }} {% endif %} {% endblock %} {% block beforeMain %}
7-
<a class="sr-only" href="#main">Skip to content</a>
8-
<div
9-
class="bp-wrapper relative"
10-
data-barba="wrapper"
11-
data-barba-namespace="home"
12-
>
13-
{% render fragments.header() %}
14-
<main
15-
class="bp-main"
16-
role="main"
17-
id="main"
18-
{%
19-
if
20-
not
21-
data.user
22-
%}data-barba="container"
23-
{%
24-
endif
25-
%}
1+
{# Automatically extends the right outer layout and also handles AJAX situations #}
2+
{% extends data.outerLayout %}
3+
{% import 'fragments/fragments.html' as fragments %}
4+
5+
{% set title = data.piece.title or data.page.title %}
6+
7+
{% block title %}
8+
{{ title }}
9+
{% if not title %}
10+
{{ apos.log('Looks like you forgot to override the title block in a template that does not have access to an Apostrophe page or piece.') }}
11+
{% endif %}
12+
{% endblock %}
13+
14+
{# ✅ Add favicon in the <head> section #}
15+
{% block extraHead %}
16+
<link rel="icon" href="{{ apos.asset.url('/modules/asset/favicon/favicon.ico') }}" type="image/x-icon">
17+
{% endblock %}
18+
19+
{% block beforeMain %}
20+
<a class="sr-only" href="#main">Skip to content</a>
21+
<div
22+
class="bp-wrapper relative"
23+
data-barba="wrapper"
24+
data-barba-namespace="home"
2625
>
27-
{% render fragments.breadcrumbs() %}
28-
<div class="sf-container">
29-
{% endblock %} {% block main %} {# Usually, your page templates in the
30-
@apostrophecms/pages module will override this block. It is safe to assume
31-
this is where your page-specific content should go. #} {% endblock %} {%
32-
block afterMain %}
33-
</div>
34-
</main>
35-
{% render fragments.footer() %}
36-
<script type="text/javascript"></script>
37-
</div>
38-
{# Close .bp-wrapper #} {% endblock %}
26+
{% render fragments.header() %}
27+
<main
28+
class="bp-main"
29+
role="main"
30+
id="main"
31+
{% if not data.user %}
32+
data-barba="container"
33+
{% endif %}
34+
>
35+
{% render fragments.breadcrumbs() %}
36+
<div class="sf-container">
37+
{% endblock %}
38+
39+
{% block main %}
40+
{# Usually, your page templates in the @apostrophecms/pages module will override this block. It is safe to assume this is where your page-specific content should go. #}
41+
{% endblock %}
42+
43+
{% block afterMain %}
44+
</div>
45+
</main>
46+
{% render fragments.footer() %}
47+
<script type="text/javascript"></script>
48+
</div>
49+
{# Close .bp-wrapper #}
50+
{% endblock %}

0 commit comments

Comments
 (0)