Installation issue: pthreadpool not buildable on air-gapped systems

[williampiat3]

Steps to reproduce the issue

pthreadpool is pulling ressources from a master branch of FXdiv

    resource(
        name="fxdiv",
        git="https://github.com/Maratyszcza/FXdiv.git",
        branch="master",
        destination="deps",
        placement="fxdiv",
    )

This prevents building pthreadpool in air-gaped systems.
The repository has not seen a commit in 6 years, a release can be made to have a proper checksumed file

Error message

Fetch Error on air gaped systems

Information on your system

linux rhel9 zen3

Additional information

No response

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
• I have uploaded the build log and environment files
• I have searched the issues of this repo and believe this is not a duplicate

[williampiat3]

This fix is needed for this PR: #5270

[adamjstewart]

The repository has not seen a commit in 6 years, a release can be made to have a proper checksumed file

I think it is very unlikely we will see a release because it has not seen a commit in 6 years.

Can you clarify why this is an issue? Does spack fetch not download resources? If that's the only problem, then this sounds more like a spack issue than a spack-packages issue. We can also pin to a specific commit if that changes something.

[williampiat3]

Attempting to build this recipe will inevitable end up trying to fetch from github even though you have the tar file in your local cache because there is no sha256 to identify the downloaded sources.
Therefore if you have a machine that fetches the source and provide it to an air gapped system it will still try to pull from github since the build recipe wants github master branch

Maybe pinning a commit might fix this but I don't see this option in resource signature

EDIT: Pinning DOES help! I will add the commit in the recipes of psimd and fxdiv