From 8195d065495dc72a0c6ea606d3f31fdeb4603879 Mon Sep 17 00:00:00 2001 From: Michael Newton Date: Wed, 17 Sep 2025 12:36:11 -0600 Subject: [PATCH] use less specific argument type You can't get an instance of `PublicKeyInfo` very easily since e.g. `PublicKeyInfo::fromPEM()` returns an instance of `OneAsymmetricKey`. --- lib/X509/Certificate/TBSCertificate.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/X509/Certificate/TBSCertificate.php b/lib/X509/Certificate/TBSCertificate.php index 1b2d48b..93e1bbb 100644 --- a/lib/X509/Certificate/TBSCertificate.php +++ b/lib/X509/Certificate/TBSCertificate.php @@ -12,7 +12,7 @@ use Sop\CryptoBridge\Crypto; use Sop\CryptoTypes\AlgorithmIdentifier\AlgorithmIdentifier; use Sop\CryptoTypes\AlgorithmIdentifier\Feature\SignatureAlgorithmIdentifier; -use Sop\CryptoTypes\Asymmetric\PrivateKeyInfo; +use Sop\CryptoTypes\Asymmetric\OneAsymmetricKey; use Sop\CryptoTypes\Asymmetric\PublicKeyInfo; use Sop\X501\ASN1\Name; use Sop\X509\Certificate\Extension\AuthorityKeyIdentifierExtension; @@ -524,11 +524,11 @@ public function toASN1(): Sequence * Create signed certificate. * * @param SignatureAlgorithmIdentifier $algo Algorithm used for signing - * @param PrivateKeyInfo $privkey_info Private key used for signing + * @param OneAsymmetricKey $privkey_info Private key used for signing * @param null|Crypto $crypto Crypto engine, use default if not set */ public function sign(SignatureAlgorithmIdentifier $algo, - PrivateKeyInfo $privkey_info, ?Crypto $crypto = null): Certificate + OneAsymmetricKey $privkey_info, ?Crypto $crypto = null): Certificate { $crypto = $crypto ?? Crypto::getDefault(); $tbs_cert = clone $this;