Kdump unit test failures.

[vivekverma-arista]

The following tests do no mock /proc/cmdline but rather end up reading the actual /proc/cmdline from the host erroneously-
 

1. hostcfgd_fips_test.py
2. hostcfgd_logging_test.py
3. hostcfgd_rsyslog_test.py
4. hostcfgd_test.py
    
   Even though a cmdline file is committed it was never used by the tests other than hostcfgd_test.py, instead the code ends up using the /proc/cmdline of the machine on which the test runs. The tests fail if the KDUMP is enabled on the machine where test is running, with a keyerror which is a false positive. As the test does not expect kdump to be enabled, the mocked config db for these tests does not have KDUMP configured as a result hostcfgd fails to retrieve KDUMP from config_db after it sees crashkernel parameteres in /proc/cmdline at this point https://github.com/sonic-net/sonic-host-services/blob/master/scripts/hostcfgd#L1195
    
   The proposed fix is to mock /proc/cmdline for every test instead of reading the "real" /proc/cmdline.

>       host_config_daemon = hostcfgd.HostConfigDaemon()                                                                               
                                                                                                                                       
tests/hostcfgd/hostcfgd_fips_test.py:98:                                                                                               
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
scripts/hostcfgd:2171: in __init__                                                                                                     
    self.kdumpCfg = KdumpCfg(self.config_db)
scripts/hostcfgd:1177: in __init__
    self.init_kdump_config_from_cmdline()
scripts/hostcfgd:1195: in init_kdump_config_from_cmdline
    kdump_config = self.config_db.get_entry("KDUMP", "config")
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <tests.common.mock_configdb.MockConfigDb object at 0x7f5117baec10>, key = 'KDUMP', field = 'config'

    def get_entry(self, key, field):
>       return MockConfigDb.CONFIG_DB[key][field]
E       KeyError: 'KDUMP'

[vivekverma-arista]

#351 raised for this

[sertem-ciena]

Also hitting this issue building the master branch on a host with crashkernel set in /proc/cmdline

=========================== short test summary info ============================ FAILED tests/hostcfgd/hostcfgd_fips_test.py::TestHostcfgdFIPS::test_hostcfgd_fips_disable - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_fips_test.py::TestHostcfgdFIPS::test_hostcfgd_fips_enable - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_fips_test.py::TestHostcfgdFIPS::test_hostcfgd_fips_enforce - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_fips_test.py::TestHostcfgdFIPS::test_hostcfgd_fips_enforce_reconf - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_logging_test.py::TestHostcfgLogging::test_rsyslog_handle_modified - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_rsyslog_test.py::TestHostcfgdRSyslog::test_rsyslog_handle_add_server - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_rsyslog_test.py::TestHostcfgdRSyslog::test_rsyslog_handle_change_global - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_rsyslog_test.py::TestHostcfgdRSyslog::test_rsyslog_handle_change_server - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_rsyslog_test.py::TestHostcfgdRSyslog::test_rsyslog_handle_empty - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_rsyslog_test.py::TestHostcfgdRSyslog::test_rsyslog_handle_the_same_config - KeyError: 'KDUMP' FAILED tests/hostcfgd/hostcfgd_test.py::TestHostcfgdDaemon::test_kdump_event - AssertionError: 'check_call' does not contain all of (call(['sonic-kdump-config', '--disable']), call(['sonic-kdump-config', '--memory', '0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-16G:448M,16G-32G:768M,32G-:1G'])) in its call list, found [call(['sonic-kdump-config', '--enable']), call(['sonic-kdump-config', '--memory', 'auto'])] instead FAILED tests/hostcfgd/hostcfgd_test.py::TestHostcfgdDaemon::test_kdump_load - AssertionError: 'check_call' does not contain all of (call(['sonic-kdump-config', '--enable']), call(['sonic-kdump-config', '--num_dumps', '3']), call(['sonic-kdump-config', '--memory', '0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-16G:448M,16G-32G:768M,32G-:1G']), call(['sonic-kdump-config', '--remote']), call(['sonic-kdump-config', '--ssh_string', 'user@localhost']), call(['sonic-kdump-config', '--ssh_path', '/a/b/c'])) in its call list, found [] instead FAILED tests/hostcfgd/hostcfgd_test.py::TestMemoryStatisticsCfgd::test_memory_statistics_handler_exception - KeyError: 'KDUMP' ============ 13 failed, 630 passed, 15 warnings in 84.67s (0:01:24) ============ [ FAIL LOG END ] [ target/python-wheels/trixie/sonic_host_services-1.0-py3-none-any.whl ]