While this issue is better suited to the sonic-mgmt repo, I am raising it here so the people who are familiar with it can see it.
Before my time it appears we made a decision to add the gNMI sonic-mgmt test tooling to the doocker-ptf container. This makes testing a bit more complex, as we have to run test commands in a separate container and exit under a predefined condition, typically a timeout or similar.
If instead the tooling was in the sonic-mgmt container, the test itself could directly execute the tooling and we could stream output as it occurs. Nexthop is investigating implementing gnmic in the sonic-mgmt container rather than the docker-ptf, and the results are looking much cleaner.
Is there any reason why we have added tooling to docker-ptf container in the first place that I am unaware of?
@sneelam20 @hdwhdw
While this issue is better suited to the sonic-mgmt repo, I am raising it here so the people who are familiar with it can see it.
Before my time it appears we made a decision to add the gNMI sonic-mgmt test tooling to the doocker-ptf container. This makes testing a bit more complex, as we have to run test commands in a separate container and exit under a predefined condition, typically a timeout or similar.
If instead the tooling was in the sonic-mgmt container, the test itself could directly execute the tooling and we could stream output as it occurs. Nexthop is investigating implementing gnmic in the sonic-mgmt container rather than the docker-ptf, and the results are looking much cleaner.
Is there any reason why we have added tooling to docker-ptf container in the first place that I am unaware of?
@sneelam20 @hdwhdw