Skip to content

Bug:Flush entry type all should be queried and used only when supported #27835

Description

@dgsudharsan

Is it platform specific

generic

Importance or Severity

Critical

Description of the bug

Recent changes to suppport EVPN MH sonic-net/sonic-swss#4615 introduced the concept of flush all types of entries
https://github.com/sonic-net/sonic-swss/blob/e63e670c1bf2b7b24280b81b3302f5b29a79f476/orchagent/fdborch.cpp#L1517. This is called during updateVlanMember del scenario as well as removeBrdigePort

https://github.com/sonic-net/sonic-swss/blob/e63e670c1bf2b7b24280b81b3302f5b29a79f476/orchagent/fdborch.cpp#L1753

https://github.com/sonic-net/sonic-swss/blob/e63e670c1bf2b7b24280b81b3302f5b29a79f476/orchagent/portsorch.cpp#L7463

This creates an issue when vendor SAI doesn't support it.

2026 Jun 11 14:08:05.272621 sonic ERR swss#orchagent: :- flushAllFDBEntries: Flushing all FDB failed. rv:-131070
2026 Jun 11 11:08:05.273852 sonic ERR syncd#SDK: [SAI_UTILS.ERR] client_pid=22, ./src/mlnx_sai_utils.c[1334]- sai_atribute_value_type_enum_validate: Failed to validate SAI_FDB_FLUSH_ATTR_ENTRY_TYPE value - enum value SAI_FDB_FLUSH_ENTRY_TYPE_ALL is not supported
2026 Jun 11 11:08:05.273857 sonic ERR syncd#SDK: [SAI_UTILS.ERR] client_pid=22, ./src/mlnx_sai_utils.c[1907]- check_attribs_on_create_without_oid: Failed attributes check
2026 Jun 11 14:08:05.274062 sonic ERR swss#orchagent: :- flushAllFDBEntries: Flushing all FDB failed. rv:-131071
2026 Jun 11 14:08:05.274072 sonic ERR swss#orchagent: :- meta_generic_validation_remove: object 0x3a0000000005ea reference count is 4, can't remove
2026 Jun 11 14:08:05.274074 sonic ERR swss#orchagent: :- removeBridgePort: Failed to remove bridge port PortChannel0001 from default 1Q bridge, rv:-17
2026 Jun 11 11:08:39.253965 sonic ERR syncd#SDK: [SAI_UTILS.ERR] client_pid=22, ./src/mlnx_sai_utils.c[1334]- sai_atribute_value_type_enum_validate: Failed to validate SAI_FDB_FLUSH_ATTR_ENTRY_TYPE value - enum value SAI_FDB_FLUSH_ENTRY_TYPE_ALL is not supported
2026 Jun 11 11:08:39.253994 sonic ERR syncd#SDK: [SAI_UTILS.ERR] client_pid=22, ./src/mlnx_sai_utils.c[1907]- check_attribs_on_create_without_oid: Failed attributes check

It is not correct to flush static entries as well as these are user configured entries and meant to be persistent irrespective of other changes.

Request to revert this change.

Steps to Reproduce

Create and remove vlan member should result in these logs in vendor SAI doesn't support flush all

Actual Behavior and Expected Behavior

No errors. Flush by default should flush only dynamic entries.

Relevant log output

Output of show version, show techsupport

Attach files (if any)

No response

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions