Bug: fib suppression performance improvement

[mike-dubrovsky]

Is it platform specific

generic

Importance or Severity

Critical

Description of the bug

When FIB suppression is enabled, orchagent sends pub/sub notifications to fpmsyncd and also populates APPL_STATE_DB. APPL_STATE_DB is used only for warm reboot, but we can recreate the needed information from APPL_DB and ASIC_DB.

Steps to Reproduce

see above

Actual Behavior and Expected Behavior

do not populate APP_STATE_DB

Relevant log output

Output of show version, show techsupport

Attach files (if any)

No response

[gechiang]

@mike-dubrovsky , community mentioned you already have a PR for this. although I did not see a link to it.
let us know if you still need further discussion on this or just link your PR to this issue.
Thanks!

[mike-dubrovsky]

@gechiang
@dgsudharsan
This is for community discussion. Not sure if the community will like it.

(I only have a PR to stop both pub/sub and APP_STATE_DB when FIB suppression is disabled.
sonic-net/sonic-swss#4333
#26151
sonic-net/sonic-utilities#4361
sonic-net/sonic-mgmt#22916)