Bug: swss build failure on latest sonic-swss-common

[yanmarkman]

Is it platform specific

generic

Importance or Severity

Critical

Description of the bug

AMD64 branch "master" build failed on incorrect variable cast compare/set in file
swss-common/src/types/consumerstatetable.rs "rustic"
Refer log below

Steps to Reproduce

Build ARCH=amd64 (other ARCHes just not tested)

Actual Behavior and Expected Behavior

Build passed without failure

Relevant log output

[ FAIL LOG START ] [ target/debs/bookworm/swss_1.0.0_amd64.deb ]
..........................................................
   Compiling tracing-error v0.2.1
error[E0600]: cannot apply unary operator `-` to type `u32`
  --> /var/ymarkman/.cargo/git/checkouts/sonic-swss-common-f127700b9bf1a3a6/d6ccff7/crates/swss-common/src/types/consumerstatetable.rs:41:22
   |
41 |             if fd == -1 {
   |                      ^^ cannot apply unary operator `-`
   |
   = note: unsigned values cannot be negated
help: you may have meant the maximum value of `u32`
   |
41 -             if fd == -1 {
41 +             if fd == u32::MAX {
   |

error[E0308]: mismatched types
  --> /var/ymarkman/.cargo/git/checkouts/sonic-swss-common-f127700b9bf1a3a6/d6ccff7/crates/swss-common/src/types/consumerstatetable.rs:44:45
   |
44 |             let fd = BorrowedFd::borrow_raw(fd);
   |                      ---------------------- ^^ expected `i32`, found `u32`
   |                      |
   |                      arguments to this function are incorrect
   |
note: associated function defined here
  --> /rustc/05f9846f893b09a1be1fc8560e33fc3c815cfecb/library/std/src/os/fd/owned.rs:73:25
help: you can convert a `u32` to an `i32` and panic if the converted value doesn't fit
   |
44 |             let fd = BorrowedFd::borrow_raw(fd.try_into().unwrap());
   |                                               ++++++++++++++++++++

   Compiling color-eyre v0.6.5
error[E0600]: cannot apply unary operator `-` to type `u32`
  --> /var/ymarkman/.cargo/git/checkouts/sonic-swss-common-f127700b9bf1a3a6/d6ccff7/crates/swss-common/src/types/subscriberstatetable.rs:54:22
   |
54 |             if fd == -1 {
   |                      ^^ cannot apply unary operator `-`
   |
   = note: unsigned values cannot be negated
help: you may have meant the maximum value of `u32`
   |
54 -             if fd == -1 {
54 +             if fd == u32::MAX {
   |

error[E0308]: mismatched types
  --> /var/ymarkman/.cargo/git/checkouts/sonic-swss-common-f127700b9bf1a3a6/d6ccff7/crates/swss-common/src/types/subscriberstatetable.rs:57:45
   |
57 |             let fd = BorrowedFd::borrow_raw(fd);
   |                      ---------------------- ^^ expected `i32`, found `u32`
   |                      |
   |                      arguments to this function are incorrect
   |
note: associated function defined here
  --> /rustc/05f9846f893b09a1be1fc8560e33fc3c815cfecb/library/std/src/os/fd/owned.rs:73:25
help: you can convert a `u32` to an `i32` and panic if the converted value doesn't fit
   |
57 |             let fd = BorrowedFd::borrow_raw(fd.try_into().unwrap());
   |                                               ++++++++++++++++++++

error[E0600]: cannot apply unary operator `-` to type `u32`
  --> /var/ymarkman/.cargo/git/checkouts/sonic-swss-common-f127700b9bf1a3a6/d6ccff7/crates/swss-common/src/types/zmqconsumerstatetable.rs:52:22
   |
52 |             if fd == -1 {
   |                      ^^ cannot apply unary operator `-`
   |
   = note: unsigned values cannot be negated
help: you may have meant the maximum value of `u32`
   |
52 -             if fd == -1 {
52 +             if fd == u32::MAX {
   |

error[E0308]: mismatched types
  --> /var/ymarkman/.cargo/git/checkouts/sonic-swss-common-f127700b9bf1a3a6/d6ccff7/crates/swss-common/src/types/zmqconsumerstatetable.rs:55:45
   |
55 |             let fd = BorrowedFd::borrow_raw(fd);
   |                      ---------------------- ^^ expected `i32`, found `u32`
   |                      |
   |                      arguments to this function are incorrect
   |
note: associated function defined here
  --> /rustc/05f9846f893b09a1be1fc8560e33fc3c815cfecb/library/std/src/os/fd/owned.rs:73:25
help: you can convert a `u32` to an `i32` and panic if the converted value doesn't fit
   |
55 |             let fd = BorrowedFd::borrow_raw(fd.try_into().unwrap());
   |                                               ++++++++++++++++++++

Some errors have detailed explanations: E0308, E0600.
For more information about an error, try `rustc --explain E0308`.

Output of show version, show techsupport

Attach files (if any)

No response

[volodymyrsamotiy]

@qiluo-msft , could you please help to check? Thanks

[qiluo-msft]

@qiluo-msft , could you please help to check? Thanks

ack

[qiluo-msft]

Currently there are 3 solutions we are trying, we can take any one of them:

1. Respect Cargo.lock for dependencies version sonic-swss#4028
2. Fixes #24661: Update reference to sonic-dash-ha and sonic-swss-common #24663
3. Revert "Fix risky unwrap(), expect(), and casting" sonic-swss-common#1118

[cpackham-atlnz]

will this get back ported to 202511?

[govi-nokia]

Yes, this has to be back ported to 202511 as well. That is also failing.

[yanmarkman]

Current TRIXIE github.com/saiarcot895/sonic-buildimage (candidate to the 202511) has NO this problem

[volodymyrsamotiy]

Looks like this issue is seen again on 202511.
For example last build on Azure pipeline failed with the same error: https://dev.azure.com/mssonic/build/_build/results?buildId=996341&view=logs&j=d37bc48d-29a0-534f-a1dc-3d699deb17a6&t=d31d2d46-3ae6-5432-200f-6da25f8a20cc&l=15475

@qiluo-msft , could you please help to check?