Although I appreciate the existence of this package, there are multiple problems with it:
- Barely maintained, and PR's changes are very breaking. This is a near-PRIMITIVE type, but the implementation is not consistent. This means people will have to change their whole project :S (as I have to do now)
- Outputs
any on toJSON() with a property:value structure. This is not how I would serialize, and it is quite a dealbreaker. I would serialize in a flat manner value directly, which is consistent with f.e. C#. Now I have to intercept the Guid and fix it.
- People should implement the Guid Primitive themselves by looking at a gist, instead of relying on something which
doesnt fit all. Having total control over the guid's serialization setting is a must.
Again, I really appreciate the package and the effort, but the fact that there are so many downloads made me very worried. This is one of the most used primitives on an API side (especially .NET Core).
I can PR something, but looking at the current amount of open PR's those should be processed first. I understand the backwards-compatible hold-up, but this is a limbo state.
Although I appreciate the existence of this package, there are multiple problems with it:
anyon toJSON() with aproperty:valuestructure. This is not how I would serialize, and it is quite a dealbreaker. I would serialize in a flat mannervaluedirectly, which is consistent with f.e. C#. Now I have to intercept the Guid and fix it.doesnt fit all. Having total control over the guid's serialization setting is a must.Again, I really appreciate the package and the effort, but the fact that there are so many downloads made me very worried. This is one of the most used primitives on an API side (especially .NET Core).
I can PR something, but looking at the current amount of open PR's those should be processed first. I understand the
backwards-compatiblehold-up, but this is a limbo state.