feat(SmartGeneration): mirror backend skip rules in step-2 auto-select#37
Merged
Conversation
The post-profile checkbox state was filtering only by has_values / value_rows, which kept always-zero numerics, constant booleans (e.g. customer_facing Int8 with min=max=0) and constant-empty strings checked even though the backend would skip them at build time. Auto-select now applies the same cascade as cubeBuilder.processColumns: - has_values === false → off - NUMBER with min===max===0 → off - BOOLEAN with min===max OR unique_values===1 (constant flag) → off - STRING/UUID with unique_values===0, or =1 with lc value '', '0', 0, null, or whitespace-only → off - Anything else → on User can still override individual checkboxes in the UI; this only controls the default state on profile completion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
hamdi-ibrahim
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to smartdataHQ/synmetrix smart-gen improvements. The post-profile checkbox state was filtering only by
has_values/value_rows, which kept always-zero numerics, constant booleans (e.g.customer_facing Int8with min=max=0) and constant-empty strings checked even though the backend would skip them at build time.Auto-select now applies the same cascade as
cubeBuilder.processColumns:has_values === false→ offmin===max===0→ offmin===maxORunique_values===1→ offunique_values===0, or=1with single LC value being''/'0'/0/null/ whitespace-only → offUser can still override individual checkboxes; this only controls the default state on profile completion.
Test plan
customer_facing Int8(min=max=0) → checkbox starts uncheckedcommerce.products.line_discounted Array(Nullable(Bool))of all-NULL or all-false → unchecked🤖 Generated with Claude Code