Potential Vulnerability in Cloned Code#65
Merged
Conversation
* add NULL checks in cJSON_SetValuestring Fixes #803(CVE-2023-50472) * add NULL check in cJSON_InsertItemInArray Fixes #802(CVE-2023-50471)
Contributor
Author
|
Hi @sipsorcery, thanks for merging our PRs. We plan to request CVEs for this issue. Just wanna make sure if you are OK with us proceeding with the CVE submissions. Thank you! |
Owner
|
@tabudz do you mean for gstreamer or for this repo? There's not a lot of point lodging one for this repo since the code here is only for itnegration tests and there are no end user apps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Our tool detected a potential vulnerability in gstreamer/cJSON.c which was cloned from DaveGamble/cJSON but did not receive the security patch applied. The original issue was reported and fixed under https://nvd.nist.gov/vuln/detail/cve-2023-50472.
Proposed Fix
Apply the same patch as the one in DaveGamble/cJSON to eliminate the vulnerability.
Reference
https://nvd.nist.gov/vuln/detail/cve-2023-50472
DaveGamble/cJSON@60ff122