From bb099a4b999cad0d87d6b1ee1b929ae24c950b1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yann-Ga=C3=ABl?= Date: Fri, 31 Aug 2018 15:48:27 +0000 Subject: [PATCH 1/2] Update ITicketIterator.java --- sdm/src/java/iterator/ITicketIterator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdm/src/java/iterator/ITicketIterator.java b/sdm/src/java/iterator/ITicketIterator.java index af2fafa..3a88f62 100644 --- a/sdm/src/java/iterator/ITicketIterator.java +++ b/sdm/src/java/iterator/ITicketIterator.java @@ -2,7 +2,7 @@ import java.util.Iterator; -public interface ITicketIterator extends Iterator +public interface ITicketIterator extends Iterator // Is this interface really necessary? In any case you could keep it though! { boolean hasNext(); From b0c8e003f1bb3d150964450953af2d35f2ce9488 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yann-Ga=C3=ABl?= Date: Fri, 31 Aug 2018 16:09:42 +0000 Subject: [PATCH 2/2] Update DoubleLockSingleton.java --- sdm/src/java/singleton/DoubleLockSingleton.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sdm/src/java/singleton/DoubleLockSingleton.java b/sdm/src/java/singleton/DoubleLockSingleton.java index 56de077..38eb6cc 100644 --- a/sdm/src/java/singleton/DoubleLockSingleton.java +++ b/sdm/src/java/singleton/DoubleLockSingleton.java @@ -3,12 +3,12 @@ import java.util.Random; public class DoubleLockSingleton { - int behaviour; - private static DoubleLockSingleton new_singleton = null; + int behaviour; // Private and final? + private static DoubleLockSingleton new_singleton = null; // NewSingleton private DoubleLockSingleton() { - Random rand = new Random(); - behaviour = rand.nextInt(50); + Random rand = new Random(); // rand is unnecessary + behaviour = rand.nextInt(50); // this.behaviour } public static DoubleLockSingleton getInstance() {