explicit-timer-delay: avoid unsafe never reports and simplify fixer path

Author: azat-io

rules/explicit-timer-delay.js

@@ -92,41 +92,31 @@ const create = context => {
 				return;
 			}
 
-			const problem = {
+			return {
 				node,
 				messageId: MESSAGE_ID_MISSING_DELAY,
 				data: {name},
-			};
-
-			if (firstArgument && firstArgument.type !== 'SpreadElement') {
-				problem.fix = fixer => fixer.insertTextAfterRange(
+				fix: fixer => fixer.insertTextAfterRange(
 					getParenthesizedRange(firstArgument, context), ', 0',
-				);
-			}
-
-			return problem;
+				),
+			};
 		}
 
-		if (mode === MODE_NEVER && hasDelayArgument) {
+		if (mode === MODE_NEVER && arguments_.length === 2) {
 			const delayArgument = arguments_[1];
 
 			if (isZeroDelay(delayArgument)) {
-				const problem = {
+				return {
 					node: delayArgument,
 					messageId: MESSAGE_ID_REDUNDANT_DELAY,
 					data: {name},
-				};
-
-				if (arguments_.length === 2) {
-					problem.fix = function (fixer) {
+					fix(fixer) {
 						const [firstArgument] = arguments_;
 						const [, firstArgumentEnd] = getParenthesizedRange(firstArgument, context);
 						const [, delayArgumentEnd] = getParenthesizedRange(delayArgument, context);
 						return fixer.removeRange([firstArgumentEnd, delayArgumentEnd]);
-					};
-				}
-
-				return problem;
+					},
+				};
 			}
 		}
 	});

test/explicit-timer-delay.js

@@ -60,10 +60,18 @@ test({
 			code: 'setInterval(callback, 100);',
 			options: ['never'],
 		},
+		{
+			code: 'setInterval(callback, 0, arg1);',
+			options: ['never'],
+		},
 		{
 			code: 'setTimeout(callback, 500, arg1);',
 			options: ['never'],
 		},
+		{
+			code: 'setTimeout(callback, 0, arg1, arg2);',
+			options: ['never'],
+		},
 	],
 	invalid: [
 		{
@@ -244,10 +252,5 @@ test({
 			options: ['never'],
 			errors: [{messageId: MESSAGE_ID_REDUNDANT_DELAY}],
 		},
-		{
-			code: 'setTimeout(callback, 0, arg1, arg2);',
-			options: ['never'],
-			errors: [{messageId: MESSAGE_ID_REDUNDANT_DELAY}],
-		},
 	],
 });