fix(core/select): Make disabled prop work for select items#2567
Conversation
🦋 Changeset detectedLatest commit: e0640fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ix-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new disabled property to the ix-select-item component, reflecting the state to the host, propagating it to the underlying ix-dropdown-item, and ensuring disabled items are excluded from mouse and keyboard selection. It updates the Angular, React, and Vue wrappers, and adds unit and component tests. The reviewer feedback suggests changing the changeset type from patch to minor to align with the new API addition, and adding an axe-based accessibility scan to the component tests to ensure accessibility compliance.
danielleroux
left a comment
danielleroux
left a comment
There was a problem hiding this comment.
Searching a disabled item (if its the last one) will show a scrollbar
- Disable Item 2 (Via dev console or local)
- Search for "Item 2"
Clarification needed for disabled item which is selected programmatically
- Disable Item 2 (Via dev console or local)
- Set value to "2"
dmytro-halimov
force-pushed
the
fix/IX-4149-select-disabled
branch
from
927555f to
e0640fe
Compare
|
|
Just for a reference here: we decided to go with native-like approach and disable only user interaction. Programmatically it's still possible to change the state of a select item. Might refined in the future |
2 participants
💡 What is the current behavior?
"disabled" prop is ignored when set to select item.
JIRA ref: IX-4149
Docs repo PR: siemens/ix-docs#241
🆕 What is the new behavior?
"disabled" prop now works properly, setting it up disabled the selected item.
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support