Workaround for comments with leading or trailing \s character(s)#8
Merged
Conversation
devzom
approved these changes
Jun 12, 2025
devzom
left a comment
devzom
left a comment
There was a problem hiding this comment.
Worth to merge PR, I was doing that as overcome, this will solves many problem, thanks @freeyoung
|
@shanegenschaw can we get it merged or maybe it's worth to add trusted contributors? fyi. it's time to upgrade to node v24 |
Owner
|
sorry for the delay, not actively using this right now, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a user might add a
\s(e.g.\n) at the end of the comment unintentionally and then would be confused as to why the trigger wouldn't work as expected 🙈This pull request trims the comment body before doing the regex match as a workaround.