Skip to content

feat: add unit as kwarg to Well #116

Description

@eriktoller

I think it would be a good idea to add an optional unit="m" kwarg to the Well class.

obs = gr.Well(name="obs", is_reference=False, timeseries=obs_series, unit="m")
ref = gr.Well(name="ref", is_reference=True, timeseries=ref_series, unit="mm")

then the Well instance can convert to the SI units if needed.

class Well:
    """
    ...
    """

    def __init__(
        self,
        name,
        is_reference,
        timeseries: pd.Series | None = None,
        unit: str = "m",
    ):
        """
        Initialize a WellBase object.
        """

        # Initialize attributes
        ...

        # Check unit
        if unit != "m":
            self.update_unit()

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions