gopls setup

[yzhou216]

Is there any way to set golines as the formatted for gopls? I can't find useful info in gopls's documentation.

[fgimian]

I don't believe so based on https://github.com/golang/vscode-go/wiki/settings#goformattool 😢

Cheers
Fotis

[yzhou216]

I don't believe so based on https://github.com/golang/vscode-go/wiki/settings#goformattool 😢

Cheers Fotis

Thanks for the reply! That's a bummer, and I guess I have to open an issue for gopls.

[fgimian]

I don't believe so based on https://github.com/golang/vscode-go/wiki/settings#goformattool 😢
Cheers Fotis

Thanks for the reply! That's a bummer, and I guess I have to open an issue for gopls.

I think ideally first #100 would be solved, and then we could use golines in combination with gofumpt. Alternatively, it would be nice if gofumpt integrated golines.

Even in VS Code, having to install an additional extension which doesn't respect the formatOnSave option for golines isn't ideal.

All the best 😄
Fotis

[yzhou216]

I've seen other language servers allow the config in which the user can specify a program in PATH for formatting. For example, nil, the formatter for Nix. I'm not sure why gopls chose to hardcode the config to a few options, but my guess it that the devs are really opinionated. I currently have something like this for my Eglot setup for GNU Emacs, where I set the formatter for Nix to be nixfmt.

(dolist (config '((scheme-mode . ("scheme-langserver"))
		  (nix-ts-mode . ("nil" :initializationOptions
                                  (:formatting (:command ["nixfmt"]))))
                  (rust-ts-mode . ("rust-analyzer" :initializationOptions
                                   (:check (:command "clippy"))))))
  (let ((major-mode (car config))
        (contact (cdr config)))
    (add-to-list 'eglot-server-programs (cons major-mode contact))))

I was hoping to do the something similar with golines, and set it as the formatter for gopls. Have you tried to configure the language server to achieves this?

[fgimian]

I've seen other language servers allow the config in which the user can specify a program in PATH for formatting. For example, nil, the formatter for Nix. I'm not sure why gopls chose to hardcode the config to a few options, but my guess it that the devs are really opinionated. I currently have something like this for my Eglot setup for GNU Emacs, where I set the formatter for Nix to be nixfmt.

(dolist (config '((scheme-mode . ("scheme-langserver"))
(nix-ts-mode . ("nil" :initializationOptions
(:formatting (:command ["nixfmt"]))))
(rust-ts-mode . ("rust-analyzer" :initializationOptions
(:check (:command "clippy"))))))
(let ((major-mode (car config))
(contact (cdr config)))
(add-to-list 'eglot-server-programs (cons major-mode contact))))

I was hoping to do the something similar with golines, and set it as the formatter for gopls. Have you tried to configure the language server to achieves this?

I haven't actually. As per the docs, there does seem a way to set a custom formatter, but then I think the problem is that golines will be the only formatter. This may be OK if you are happy with the b ase formatter used by golines, I personally like gofumpt as my base formatter.

Let me know if you get it working!

Cheers
Fotis

[ccoVeille]

Hi guys,

I join the discussion. Maybe you will find my feedback pointless.

But since golines was added to golangci-lint v2 formatter I'm using gofumpt+golines in golangci-lint and I format my code with golangci-lint fmt

I managed to make it work in vscode by using golangci-lint-v2 formatter and configured .golangci-lint to use golines + gofumpt as a formatter.

I initially thought the discussion was about gopls using golines, but then I saw vscode configuration was mentioned.

Maybe I'm simply wrong and off topic, but maybe you could find this useful.

[fgimian]

Hi guys,

I join the discussion. Maybe you will find my feedback pointless.

But since golines was added to golangci-lint v2 formatter I'm using gofumpt+golines in golangci-lint and I format my code with golangci-lint fmt

I managed to make it work in vscode by using golangci-lint-v2 formatter and configured .golangci-lint to use golines + gofumpt as a formatter.

I initially thought the discussion was about gopls using golines, but then I saw vscode configuration was mentioned.

Maybe I'm simply wrong and off topic, but maybe you could find this useful.

Actually, that's really useful information. The docs at https://golangci-lint.run/welcome/integrations/ mention using golangci-lint as a custom formatter. I may give this a try myself too.

Cheers
Fotis

[yzhou216]

Hi guys,

I join the discussion. Maybe you will find my feedback pointless.

But since golines was added to golangci-lint v2 formatter I'm using gofumpt+golines in golangci-lint and I format my code with golangci-lint fmt

I managed to make it work in vscode by using golangci-lint-v2 formatter and configured .golangci-lint to use golines + gofumpt as a formatter.

I initially thought the discussion was about gopls using golines, but then I saw vscode configuration was mentioned.

Maybe I'm simply wrong and off topic, but maybe you could find this useful.

Oh, wow! Thanks for this info, I guess golangci-lint-langserver is what I need.