Legacy group search shows zero results when there should be many

[canny]

Bug was found by Lucia Nightfire in the Firestorm Preview group

• On the LL viewer, using Websearch, search groups for the term Hentai

• Observe there are many results

• Now switch to Legacy search via top menu -> World -> Legacy Search, and search Groups for the term Hentai

Observed Behaviour

• Legacy group search on the LL viewer returns zero results for the term Hentai

• This bug also reproduces on the Firestorm Beta when using LL's Legacy Search implementation.

• On the Firestorm Beta, setting the debug setting FSUseFSLegacySearch to TRUE, which uses Firestorm's Legacy search rather then LL's, the bug no longer reproduces.

https://secondlife.canny.io/admin/feedback/bug-reports/p/legacy-group-search-shows-zero-results-when-there-should-be-many

[canny]

This issue has been linked to a Canny post: Legacy group search shows zero results when there should be many 🎉

[Hecklezz]

I fixed this on Firestorms side here, and if you think this is a fine solution I can provide a PR (without the FS tagging/naming of course)-
FirestormViewer/phoenix-firestorm@d141b90

It looks like this (Screenshot of change)

Unlike with the Web API, there does not appear to be any built-in query for Adult only groups, unless I am mistaken?
Also, it appears you cannot filter groups just by moderate and not general, if you include moderate it always also shows general which is why I implemented it the way I showed above.

Also if possible, can someone please clarify what the difference between
DFQ_FILTER_MATURE = 0x1 << 22
and
DFQ_INC_MATURE = 0x1 << 25
are on the Sim side? I didn't notice any difference switching it to use DFQ_INC_MATURE like the rest of the legacy search tabs.

[akleshchev]

@Hecklezz

DFQ_INC_MATURE = 0x1 << 25

const U32 DFQ_INC_NEW_VIEWER = (DFQ_INC_PG | DFQ_INC_MATURE | DFQ_INC_ADULT); // Indicates 1.23 viewer or later
if any of the three are there, server will use 1.23 route. If not there, server will check legacy DFQ_PG_SIMS_ONLY and DFQ_MATURE_SIMS_ONLY. Legecy request route does not appear to be 'adult aware'

there does not appear to be any built-in query for Adult only groups, unless I am mistaken?

Code wise it looks like these flags should be working independently. Server form a DB request string that can include these three in any combination:
DFQ_INC_PG 'pg or less'
DFQ_INC_MATURE 'equal to mature'
DFQ_INC_ADULT 'adult or above'
if none were selected, server goes to the legacy route and does <= Mature

But there are two caveits:

1. If query text itself is classified as adult, 'adult' will be forced.
2. Agent must be adult and/or mature enabled (haven't checked where that value comes from)

Ex: If there is only DFQ_INC_ADULT, request would search for >=adult only.

For comparison, legacy route can take only one of these:
DFQ_PG_SIMS_ONLY is <=PG
DFQ_MATURE_SIMS_ONLY is = Mature
And if neither, it does <= Mature

[Hecklezz]

Code wise it looks like these flags should be working independently. Server form a DB request string that can include these three in any combination: DFQ_INC_PG 'pg or less' DFQ_INC_MATURE 'equal to mature' DFQ_INC_ADULT 'adult or above' if none were selected, server goes to the legacy route and does <= Mature

But there are two caveits:

1. If query text itself is classified as adult, 'adult' will be forced.

2. Agent must be adult and/or mature enabled (haven't checked where that value comes from)

Hmmm this is how I thought it should have worked as well, but when I was testing this a month ago and had only DFQ_INC_MATURE added as a flag, it was still finding PG groups (and of course mature as well).
Then when I tested with only DFQ_INC_ADULT as a flag, it was still finding PG and mature groups too.

I'll need to test again when I have some time, and I will reply again here if this is still what I experience.

[Hecklezz]

Alright from some further testing this search query definitely seems to not function as it should:

1. Using either DFQ_INC_PG or DFQ_INC_MATURE in the query returns both PG and Mature (moderate) groups, despite moderate groups should only be appearing if DFQ_INC_MATURE is set, but they appear for me even if only DFQ_INC_PG is set.
2. Using only DFQ_INC_ADULT still returns both PG and Mature (moderate) groups and not just adult groups.
3. DFQ_FILTER_MATURE seems to be the only flag that works to make Mature (moderate) groups not appear and only return PG groups.

[akleshchev]

I will doublecheck and open a server ticket.