Commit f73f4e5
committed
fix(render_points): scope resolved norm to matplotlib, keep datashader autoscaling
d5a811a routed continuous points through _resolve_continuous_norm, but the
resolved norm was passed to BOTH backends. For datashader the displayed value is
the per-pixel aggregate (count/sum/reduction), whose range differs from the
per-point color vector — applying a color-vector-derived vmin/vmax mis-scaled the
colorbar and painted empty pixels (purple background) instead of leaving them
transparent.
Scope the resolved norm to the matplotlib backend (where each point is colored by
its own value); datashader keeps the un-scaled fresh_norm so _apply_ds_norm
autoscales to the aggregate (honoring any explicit vmin/vmax) — the pre-d5a811a
behavior. Reverts the datashader point baselines regenerated in error.1 parent 17ebd6e commit f73f4e5
14 files changed
Lines changed: 13 additions & 9 deletions
File tree
- src/spatialdata_plot/pl
- tests/_images
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1415 | 1415 | | |
1416 | 1416 | | |
1417 | 1417 | | |
1418 | | - | |
1419 | | - | |
1420 | | - | |
1421 | | - | |
1422 | | - | |
1423 | | - | |
1424 | | - | |
1425 | | - | |
1426 | | - | |
1427 | 1418 | | |
1428 | 1419 | | |
1429 | 1420 | | |
| |||
1435 | 1426 | | |
1436 | 1427 | | |
1437 | 1428 | | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
| 1433 | + | |
1438 | 1434 | | |
1439 | 1435 | | |
1440 | 1436 | | |
| |||
1471 | 1467 | | |
1472 | 1468 | | |
1473 | 1469 | | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
1474 | 1478 | | |
1475 | 1479 | | |
1476 | 1480 | | |
| |||
Loading
0 commit comments