Use Jabba-Team/jabba instead of shyiko/jabba?

[carueda]

Hello Metals team:

First off, thanks for all the great work on Metals, not only have I been a user myself (via VSCode) but have also used some of the internals to inform my own language server for a mission scripting language I've been working on for a while (not yet open source).

In my vscode extension impl, I've recently switched to using https://github.com/Jabba-Team/jabba for the underlying java downloading functionality and it has worked very well so far. In particular, it's great to know one is using a maintained tool (shyiko/jabba#845).

I did some searching and it seems this has not been mentioned in this repo so I thought I'd enter this ticket in case it motivates some consideration. Of course, feel free to close as you deem appropriate.

[tgodzik]

Thanks for raising this! I think what we would actually want to use is the coursier which should manage to download the correct JVM version for each system. If that doesn't work correctly we can switch to the better maintained Jabba then.

[carueda]

Sounds like a good plan.

(btw, the idea of using coursier is interesting, perhaps there is -or there will be- a (I guess, a scala.js-powered) nodejs package for it? or the idea is to use some sort of REST or GraphQL API to perform the java download ... anyway, just some quick reactions, no replies requested, I shall take a closer look at coursier at some point ;)

[tgodzik]

We were thinking of downloading the right native image for coursier and then using it for all the later setup. This wouldn't even need java before running the setup.